deps: pin urllib3>=2.6.0,<3 to match tableauserverclient - #453
Open
jacalata wants to merge 1 commit into
Open
Conversation
Matches the pin declared in tableauserverclient (our direct dependency), so any Python environment installing tabcmd resolves the same urllib3 range TSC was tested with. Previously urllib3 was unpinned; pip would then pick a version compatible with TSC's constraint by transitive resolution, but the tabcmd distribution itself didn't declare compatibility bounds. No functional change — the resolved version doesn't move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
urllib3 was unpinned in tabcmd. pip resolved a compatible version
transitively through TSC, but the tabcmd distribution itself declared
no compatibility bounds. If TSC bumps its urllib3 range in a future
release, tabcmd installs could resolve to versions TSC was never tested
against.
Match TSC's declared pin directly so any Python environment installing
tabcmd resolves the same urllib3 range TSC uses in CI.
Behavior change
For users: none in practice; fresh install still resolves to
urllib3 2.6.3 today (same as before). Only the declared range changes.
The declared pin creates a duplicate source of truth with TSC. Long-term
solution is either drop this and rely on TSC's pin transitively, or
keep them in sync via a release checklist item.
Test plan
install
🤖 Generated with Claude Code