Skip to content

deps: pin urllib3>=2.6.0,<3 to match tableauserverclient - #453

Open
jacalata wants to merge 1 commit into
developmentfrom
jac/pin-urllib3
Open

deps: pin urllib3>=2.6.0,<3 to match tableauserverclient#453
jacalata wants to merge 1 commit into
developmentfrom
jac/pin-urllib3

Conversation

@jacalata

@jacalata jacalata commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Motivation

urllib3 was unpinned in tabcmd. pip resolved a compatible version
transitively through TSC, but the tabcmd distribution itself declared
no compatibility bounds. If TSC bumps its urllib3 range in a future
release, tabcmd installs could resolve to versions TSC was never tested
against.

Match TSC's declared pin directly so any Python environment installing
tabcmd resolves the same urllib3 range TSC uses in CI.

Behavior change

For users: none in practice; fresh install still resolves to
urllib3 2.6.3 today (same as before). Only the declared range changes.

The declared pin creates a duplicate source of truth with TSC. Long-term
solution is either drop this and rely on TSC's pin transitively, or
keep them in sync via a release checklist item.

Test plan

  • No functional change; resolved urllib3 version unchanged on fresh
    install

🤖 Generated with Claude Code

Matches the pin declared in tableauserverclient (our direct dependency),
so any Python environment installing tabcmd resolves the same urllib3
range TSC was tested with. Previously urllib3 was unpinned; pip
would then pick a version compatible with TSC's constraint by
transitive resolution, but the tabcmd distribution itself didn't
declare compatibility bounds.

No functional change — the resolved version doesn't move.
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py121212 0%
   _version.py111111 0%
   tabcmd.py151515 0%
   version.py955 44%
tabcmd/commands
   commands.py101010 0%
   constants.py771818 77%
   server.py1351818 87%
tabcmd/commands/auth
   session.py3945050 87%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1571818 89%
   datasources_workbooks_views_url_parser.py14255 96%
   delete_command.py601616 73%
   export_command.py1202525 79%
   get_url_command.py1274747 63%
   publish_command.py1232828 77%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py481010 79%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py3044 87%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2722 93%
   edit_site_command.py3822 95%
   list_command.py771212 84%
   list_sites_command.py2922 93%
tabcmd/commands/user
   add_users_command.py2955 83%
   create_site_users.py581111 81%
   create_users_command.py5999 85%
   delete_site_users_command.py4355 88%
   user_data.py2223131 86%
tabcmd/execution
   _version.py222 0%
   global_options.py12588 94%
   localize.py661111 83%
   logger_config.py6066 90%
   tabcmd_controller.py4277 83%
TOTAL287345884% 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant