Add Secure Boot signing guide#87
Open
Cuda-Chen wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="README.md">
<violation number="1" location="README.md:36">
P3: New Secure Boot sentence contains grammar errors that hurt readability</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| Generate test image via `make test.img`, which creates a zeroed file of 50 MiB. | ||
|
|
||
| You can then mount this image on a system with the simplefs kernel module installed. | ||
| As nowadays many computer enables UEFI Secure Boot, you can either disable Secure Boot |
There was a problem hiding this comment.
P3: New Secure Boot sentence contains grammar errors that hurt readability
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At README.md, line 36:
<comment>New Secure Boot sentence contains grammar errors that hurt readability</comment>
<file context>
@@ -33,6 +33,9 @@ You can build the kernel module and tool with `make`.
Generate test image via `make test.img`, which creates a zeroed file of 50 MiB.
You can then mount this image on a system with the simplefs kernel module installed.
+As nowadays many computer enables UEFI Secure Boot, you can either disable Secure Boot
+or sign the kernel module. To sign the module, refer to [secure-boot-signing-guide.md](./secure-boot-signing-guide.md).
+
</file context>
Suggested change
| As nowadays many computer enables UEFI Secure Boot, you can either disable Secure Boot | |
| +As many computers now have UEFI Secure Boot enabled, you can either disable Secure Boot | |
| or sign the kernel module. To sign the module, refer to [secure-boot-signing-guide.md](./secure-boot-signing-guide.md). |
fba532c to
06da008
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Secure Boot signing guide.
Summary by cubic
Add a Secure Boot signing guide and link it from the README so users can load
simplefs.koon UEFI Secure Boot systems. The guide shows Ubuntu commands to installlinux-headers-$(uname -r),mokutil,kmod, andopenssl; generate and enroll a MOK key viamokutil/MOK Manager; sign the module and verify withmodinfo—with the README noting disabling Secure Boot as an alternative.Written for commit 06da008. Summary will update on new commits.