-
Notifications
You must be signed in to change notification settings - Fork 4
test: add a hosted-runner e2e path alongside the self-hosted one #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mdozhdev
wants to merge
6
commits into
master
Choose a base branch
from
test/e2e-remote-jobs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+346
−3
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
95dbc6c
test: add a hosted-runner e2e path alongside the self-hosted one
mdozhdev 92100d1
test: TEMPORARY - run the remote e2e path on draft PRs
mdozhdev 2503fe9
test: TEMPORARY - park e2e-tests-local while the remote path is valid…
mdozhdev a7e2a68
test: stop the regtest stack expiring mid-run
mdozhdev a775823
test: TEMPORARY - run both e2e paths and keep artifacts
mdozhdev f169f4a
test: relay the stack onto loopback and gate on the remote path
mdozhdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new Tailscale step passes
TS_AUTHKEYto an action referenced by the mutablev3tag, so repointing or compromising that tag would expose the tailnet credential to unreviewed action code. Pinning the action to a reviewed commit would make the executed code immutable. How this was verified: Both new jobs providesecrets.TS_AUTHKEYdirectly totailscale/github-action@v3.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!