Skip to content

fix: harden run script#576

Merged
ovitrif merged 2 commits into
masterfrom
fix/run-after-lib-update
Jun 4, 2026
Merged

fix: harden run script#576
ovitrif merged 2 commits into
masterfrom
fix/run-after-lib-update

Conversation

@ovitrif
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif commented Jun 3, 2026

Description

This PR fixes the local ./run.sh device runner after the VSS library update:

  1. Builds against the connected iPhone destination instead of the generic iOS placeholder.
  2. Removes copied static framework stubs whose declared executable is missing before installing the app.
  3. Prints a clearer message when install succeeds but launch fails because the iPhone is locked.

This keeps the script aligned with Xcode's physical-device run path while preserving the existing build, install, and console launch flow.

Linked Issues/Tasks

N/A

Screenshot / Video

N/A

QA Notes

Manual Tests

  • 1. unlocked iPhone connected → ./run.sh: app builds, installs, launches, and attaches console output.
  • 2. locked iPhone connected → ./run.sh: app builds and installs, then prints the friendly locked-device message instead of only the raw CoreDevice error.

Automated Checks

  • git diff --check master...HEAD
  • bash -n run.sh
  • Locked-device error matcher verified with a representative CoreDevice Locked line.

@ovitrif ovitrif requested a review from pwltr June 3, 2026 17:07
@ovitrif ovitrif added this to the 2.3.0 milestone Jun 3, 2026
@ovitrif ovitrif enabled auto-merge June 3, 2026 17:07
@ovitrif ovitrif merged commit 13f3be6 into master Jun 4, 2026
10 checks passed
@ovitrif ovitrif deleted the fix/run-after-lib-update branch June 4, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants