Skip to content

Fix deprecation notice#304

Merged
bytestream merged 1 commit into
masterfrom
depreations
May 29, 2026
Merged

Fix deprecation notice#304
bytestream merged 1 commit into
masterfrom
depreations

Conversation

@bytestream
Copy link
Copy Markdown
Member

PHP Deprecated:  Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1 in /home/runner/work/api-client-php/api-client-php/test/ContainerAwareBaseTestCase.php on line 90

Copilot AI review requested due to automatic review settings May 28, 2026 22:21
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes deprecated reflection accessibility calls from the test base setup, aligning the test suite with supported PHP versions where ReflectionProperty::setAccessible() is no longer needed.

Changes:

  • Removes setAccessible(true) and setAccessible(false) around a reflected property write.
  • Keeps the existing test container injection behavior unchanged for PHP 8.1+.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bytestream bytestream merged commit 93b0f5a into master May 29, 2026
6 checks passed
@bytestream bytestream deleted the depreations branch May 29, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants