fix(ansible): drop no-op zpool item and filter - #2322
Open
brainrake wants to merge 1 commit into
Open
Conversation
zsmalloc has been zswap's default allocator since kernel 6.3 (Sept 2023), and Ubuntu noble has always shipped >= 6.8, so explicitly writing zpool=zsmalloc was a no-op on every kernel this fleet has run. Kernels >= 6.18 dropped the param entirely. Drop the item instead of guarding it, since setting it never did anything. No guard needed for the remaining params either: the original failure log shows compressor, max_pool_percent, and enabled all wrote successfully on the newest kernel observed (7.0.0-1009-aws) -- zpool was the only one that failed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
brainrake
force-pushed
the
martonboros/psql-1548-followup-drop-noop-zpool-item
branch
from
July 28, 2026 15:38
fe3170c to
902e411
Compare
brainrake
marked this pull request as ready for review
July 28, 2026 15:39
brainrake
enabled auto-merge
July 28, 2026 15:40
Collaborator
Author
brainrake
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop the
zpool: zsmallocloop item entirely — no guard needed.Why
@brainrake raised in #2321 (comment) if the default already matches the value we set, we should remove the param rather than conditionally skip it.
Confirmed: zsmalloc has been zswap's default allocator since kernel 6.3 (patch, Sept 2023). Ubuntu noble has always shipped >= 6.8, so
echo zsmalloc > .../parameters/zpoolwas a no-op.Related: PSQL-1548