ci: Fix dockerhub-release-matrix matrix generation - #2320
Queued
mmlb wants to merge 1 commit into
Queued
Conversation
brainrake
approved these changes
Jul 27, 2026
mmlb
force-pushed
the
push-rzvnmrovryxt
branch
2 times, most recently
from
July 28, 2026 17:00
ab50744 to
3ad44ea
Compare
Collaborator
Author
|
I gave up on trying to get this to build but not push in PR branches, its too much of a diff with the current setup using ansible/vars.yml for base images. Will leave that for my upcoming work to use automatic git based versioning instead. |
GITHUB_OUTPUT needs newline separated lines to separate outputs, nu's `to json` and `save` do not insert any so the file was ending up as just one long line and github does not like that. Fix it by appending a eol char to the string before saving to the file. I extracted this snippet and ran it and noticed the single-long-line and
Collaborator
Author
|
Ok my test build worked to build the images: https://github.com/supabase/postgres/actions/runs/30381275800. Canceling those CI and pushing w/o the DNM commit now. |
mmlb
enabled auto-merge
July 28, 2026 17:28
mmlb
added this pull request to the merge queue
Jul 28, 2026
Any commits made after this event will not be merged.
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 28, 2026
samrose
added this pull request to the merge queue
Jul 29, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Dockerhub release workflow is failing due to the matrix strategy json being messed up. GITHUB_OUTPUT should be newline deliminated k=v pairs but we are currently writing w/o a newline so it sees one long non-json line.
What is the new behavior?
The fix is by having newlines separate each output definition.
Additional context
See failed run: https://github.com/supabase/postgres/actions/runs/30275880815