coordinator: recover safe invocation variants - #145
Conversation
|
You have reached your Codex usage limits for security reviews. Please try again later. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4973d9f97d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| stored = archive.extractfile("project-estimation-data/" + member["name"]) | ||
| self.assertIsNotNone(stored) | ||
| self.assertEqual(stored.read(), (FIXTURE_ROOT / "bootstrap" / member["name"]).read_bytes()) | ||
| self.assertEqual(stored.read(), (DATA / member["name"]).read_bytes()) |
There was a problem hiding this comment.
When the 6.2.1 archive is built, this assertion now compares each emitted member with the same live DATA file from which the archive was produced, making the check tautological. The changed live aggregate and receipt no longer match the governed bootstrap fixture or its manifest, so manually rebound version and release hashes can pass without a new maintenance handoff. Update the producer fixture and manifest with the governed 6.2.1 handoff and continue comparing the live archive against those independently bound bytes.
AGENTS.md reference: AGENTS.md:L32-L39
Useful? React with 👍 / 👎.
| "quality_profile": "frontier", | ||
| "effort_class": "maximum", | ||
| "target_agent": None, | ||
| "author_lineage": None, |
There was a problem hiding this comment.
When a schema-7 descriptor lists multiple targets but its semantic_request.target_agent schema omits one of them, this single probe still passes because it always supplies null. The coordinator then accepts the omitted target from logical_action_targets, while _envelope_document() rejects the resulting envelope as a schema violation, turning an inconsistent signed descriptor into a misleading per-request failure instead of rejecting it during preflight. Cross-check every projected action/target combination against the semantic schema.
Useful? React with 👍 / 👎.
1 participant
Summary
Addresses #130 at source. This PR does not tag, release, install, or activate 6.2.1.
Boundary declaration
Generated and release surfaces
SKILL.mdfiles are in parity.changelog.d/fragment is present; generatedCHANGELOG.mdis unchanged.Verification
python3 -m unittest discover -s tests -t . -v— 279 passedpython3 -m unittest discover -s scripts -p 'test_*.py' -v— 448 passedpython3 -m unittest tests.test_agent_collab_coordinator tests.test_coordinator_fault_tolerance tests.test_direct_runtime_public_contract -v— 66 passed at the focused checkpoint; the final added cardinality/control regressions also pass in the full suitepython3 scripts/build_skills.py --checkpython3 scripts/build_marketplace.py --checkpython3 scripts/build-changelog.py --dry-run— fragment-only preview;--checkis release-only here because committing generatedCHANGELOG.mdis prohibited for a content PRpython3 scripts/check_release_consistency.pypython3 scripts/secret_scan.pypython3 scripts/check-public-export-safety.py --active-tree --historypython3 -m py_compile plugins/agent-collab/coordinator.py plugins/agent-collab/runtime_client.py scripts/test_verify_project_estimation_maintenance.pygit diff --checkgit verify-commitIndependent exact-head review
Google-family Gemini reviewed exact head
4973d9f97d44bcf3fba705cce7ab454778a02de7from OpenAI-family authorship and returnedAPPROVEwith no findings. The runtime recorded one provider invocation, successful cleanup, clean repository state, and repository-read evidence for the coordinator, runtime client, tests, host policy, and documentation.plugin-coordinator-review-4973d9f9910f7be70f33f2e321c7baf39861d464b5f45b703521e37327fdac2ae0aa533b00df1fd050831fe6e58048648432810f16d7d8ae3509e937707b2fe5a09e31918336d98b037227d7f4b512582289fa0ff10ee48a56c767e9760109209c6192b502cd2e9b9f5c2250544f468d25bc92572e249b02b66cdbd2f95cba32f1cdb45Review and post-condition
Tier 3: this changes the coordinator request boundary and future descriptor consumption, but does not modify the signed runtime or release supply chain. After merge, verify
maincontains the reviewed tree, source metadata consistently reports 6.2.1, and all required checks remain green. Release, installation, activation, and deployment remain separate operator-gated work.author: codex (OpenAI family)
standing_directives: AGENTS.md and public-governance coordinator, public-source, fragment-only, signed-commit, exact-head review, and no-replay boundaries followed
tier: 3
cross_check: PROCEED — Google-family Gemini exact-head code review returned APPROVE for 4973d9f; artifact 9910f7be70f33f2e321c7baf39861d464b5f45b703521e37327fdac2ae0aa533
post_condition: verify merged main contains the reviewed tree and 6.2.1 source consistency with required CI green; no release installation activation or deployment
mcp_coverage_gap: NONE
contributor_rights: OWNER-AUTHORED
operator_reserved: no