♻️(frontend) change favorite to star - #2539
Open
AntoLC wants to merge 2 commits into
Open
Conversation
AntoLC
added
enhancement
AntoLC
force-pushed
the
refacto/favorite-star
branch
from
July 29, 2026 12:53
7ecbcc1 to
6f31010
Compare
AntoLC
force-pushed
the
refacto/favorite-star
branch
from
July 29, 2026 13:06
6f31010 to
aa64e4a
Compare
Contributor
|
Size Change: +2.63 kB (+0.06%) Total Size: 4.37 MB 📦 View Changed
|
AntoLC
force-pushed
the
refacto/favorite-star
branch
from
July 29, 2026 14:04
aa64e4a to
9ab929e
Compare
AntoLC
marked this pull request as ready for review
July 29, 2026 14:08
Collaborator
Author
|
@CodeRabbit review |
✅ Action performedReview finished.
|
WalkthroughThe PR replaces document pinning terminology and visuals with starring, adds a Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/frontend/apps/impress/src/features/docs/docs-grid/components/DocsGridItem.tsx`:
- Around line 205-225: Move the access-state labels out of the aria-hidden Icon
content in DocsGridItem, keeping the appropriate translated label for public and
authenticated access visible to screen readers through a separate accessible
element. Preserve the existing icons and visual styling while ensuring both
access states have an accessible label outside Icon.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 70434a5c-f03b-4b3c-b505-fc22bdf37147
⛔ Files ignored due to path filters (12)
src/frontend/apps/impress/public/assets/icon-docs-dsfr-v4.pngis excluded by!**/*.pngsrc/frontend/apps/impress/public/assets/icon-docs.svgis excluded by!**/*.svgsrc/frontend/apps/impress/src/assets/icons/doc-all.svgis excluded by!**/*.svgsrc/frontend/apps/impress/src/assets/icons/ui-kit/clock.svgis excluded by!**/*.svgsrc/frontend/apps/impress/src/assets/icons/ui-kit/globe-lock.svgis excluded by!**/*.svgsrc/frontend/apps/impress/src/assets/icons/ui-kit/globe.svgis excluded by!**/*.svgsrc/frontend/apps/impress/src/assets/icons/ui-kit/star-filled.svgis excluded by!**/*.svgsrc/frontend/apps/impress/src/assets/icons/ui-kit/star-slash.svgis excluded by!**/*.svgsrc/frontend/apps/impress/src/assets/icons/ui-kit/star.svgis excluded by!**/*.svgsrc/frontend/apps/impress/src/assets/icons/ui-kit/trash.svgis excluded by!**/*.svgsrc/frontend/apps/impress/src/assets/icons/ui-kit/user.svgis excluded by!**/*.svgsrc/frontend/apps/impress/src/features/docs/doc-management/assets/pinned-document.svgis excluded by!**/*.svg
📒 Files selected for processing (21)
CHANGELOG.mdsrc/backend/impress/configuration/theme/default.jsonsrc/frontend/apps/e2e/__tests__/app-impress/auth.setup.tssrc/frontend/apps/e2e/__tests__/app-impress/doc-grid.spec.tssrc/frontend/apps/e2e/__tests__/app-impress/doc-header.spec.tssrc/frontend/apps/e2e/__tests__/app-impress/doc-trashbin.spec.tssrc/frontend/apps/e2e/__tests__/app-impress/header.spec.tssrc/frontend/apps/e2e/__tests__/app-impress/left-panel.spec.tssrc/frontend/apps/impress/src/features/docs/doc-header/components/DocHeaderInfo.tsxsrc/frontend/apps/impress/src/features/docs/doc-header/components/DocToolBox.tsxsrc/frontend/apps/impress/src/features/docs/doc-management/components/SimpleDocItem.tsxsrc/frontend/apps/impress/src/features/docs/doc-management/hooks/useTrans.tsxsrc/frontend/apps/impress/src/features/docs/doc-management/types.tsxsrc/frontend/apps/impress/src/features/docs/doc-search/components/DocSearchItem.tsxsrc/frontend/apps/impress/src/features/docs/docs-grid/components/DocsGrid.tsxsrc/frontend/apps/impress/src/features/docs/docs-grid/components/DocsGridActions.tsxsrc/frontend/apps/impress/src/features/docs/docs-grid/components/DocsGridItem.tsxsrc/frontend/apps/impress/src/features/left-panel/components/LefPanelTargetFilters.tsxsrc/frontend/apps/impress/src/features/left-panel/components/LeftPanelContent.tsxsrc/frontend/apps/impress/src/features/left-panel/components/LeftPanelFavorites.tsxsrc/frontend/apps/impress/src/features/left-panel/components/LeftPanelHeader.tsx
💤 Files with no reviewable changes (3)
- src/frontend/apps/impress/src/features/docs/doc-search/components/DocSearchItem.tsx
- src/frontend/apps/impress/src/features/left-panel/components/LeftPanelFavorites.tsx
- src/frontend/apps/impress/src/features/left-panel/components/LeftPanelContent.tsx
Change the favorite to star, it will be part of the grid list as the others, we can select them directly from a filter in the url.
The logo Docs seems to have again changed in the design system. We update the logo part accordingly to the new design system logo.
AntoLC
force-pushed
the
refacto/favorite-star
branch
from
July 30, 2026 08:49
9ab929e to
5337072
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Change the favorite to star, it will be part of the grid list as the others, we can select them directly from a filter in the url.
Ref: #2364
Demo