Fix manifest path separator in container build - #2688
Open
leighmcculloch wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Windows container builds by forwarding manifest paths with Linux-compatible separators.
Changes:
- Converts manifest path components to a forward-slash-delimited path.
- Preserves workspace-relative manifest paths inside
/source.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
leighmcculloch
enabled auto-merge (squash)
August 18, 2026 20:22
fnando
reviewed
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Build
--manifest-pathforcontract build --container/--imagewith a forward-slash join instead ofPath::display().Why
rel.display()renders with the host OS separator, so on Windows it emits backslashes even though the path is passed tocontract buildrunning inside a Linux container, breaking every Windows CI run (build-and-test-windows (msrv)and(latest)) since #2678 landed.Known limitations
N/A