feat: add C implementation for stats/base/dists/t/logcdf - #14694
Draft
Planeshifter wants to merge 1 commit into
Draft
feat: add C implementation for stats/base/dists/t/logcdf#14694Planeshifter wants to merge 1 commit into
stats/base/dists/t/logcdf#14694Planeshifter wants to merge 1 commit into
Conversation
Contributor
Coverage ReportNo coverage information available. |
Planeshifter
force-pushed
the
philipp/t-logcdf-c
branch
from
August 27, 2026 05:50
77b478b to
81fdb02
Compare
Contributor
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
stdlib-bot
added
the
Statistics
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_kebab_filenames
status: passed
---
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Planeshifter
force-pushed
the
philipp/t-logcdf-c
branch
from
August 27, 2026 06:07
81fdb02 to
94adf66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3872.
Description
This pull request:
@stdlib/stats/base/dists/t/logcdf, including C headers, GYP/Makefile build configurations, JavaScript/C benchmarks and examples, native unit tests, and README documentation updates. The implementation is a faithful port of the JavaScript implementation, preserving parameter validation, endpoint behavior, NaN/infinity handling, and the incomplete-beta branch selection and tail-specific formulas (log1pfor the positive tail, direct logarithms for the negative tail).Related Issues
This pull request has the following related issues:
Questions
No.
Other
isAlmostSameValuewith measured minimum ULP bounds (per RFC [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352 practice).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written primarily by Claude Code, using the merged
stats/base/dists/beta/cdfandbeta/logcdfC implementations as templates; the changes were validated locally (native addon built, all native tests passing, ULP bounds measured) before submission.@stdlib-js/reviewers