feat: publish the documentation and the card wizard from one Astro site - #489
feat: publish the documentation and the card wizard from one Astro site#489marcalexiei wants to merge 14 commits into
Conversation
|
@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel. A member of the Team first needs to authorize it. |
7e9adf6 to
54c23d8
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
e7c4022 to
b91a859
Compare
b91a859 to
05538de
Compare
martin-mfg
left a comment
There was a problem hiding this comment.
I haven't completely reviewed all changes yet. But I reviewed most of them and don't want to keep you waiting longer for initial feedback.
Btw, good idea to go with Astro+Starlight instead of MkDocs. 👍
| * Pages the wizard links to, named by the slug Starlight serves them under. | ||
| * Typed so renaming or dropping one turns every stale link into a compile error. | ||
| * | ||
| * @todo extract them statically from the config or other astro exports to build this dynamically. |
There was a problem hiding this comment.
This should stay a todo for now?
There was a problem hiding this comment.
Yes, I'll deal with this separately. There is already too much content here.
There was a problem hiding this comment.
Would it make sense to move packages/core/scripts two levels up, since this is not core-related anymore?
There was a problem hiding this comment.
Sure, I moved it.
I'm thinking about do the same with all scripts across the repo so we can have them all in one place.
There was a problem hiding this comment.
I think the links in this file should point to https://github-stats-extended.vercel.app/frontend/docs/..., because the target *.md files are not supposed to be read on GitHub anymore.
There was a problem hiding this comment.
Done, all point at https://github-stats-extended.vercel.app/frontend/docs/....
Also fixed an unrelated stale link: ../backend/src/translations.js ➡️ ../packages/core/src/translations.ts.
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <link rel="icon" href="/favicon.ico" /> |
There was a problem hiding this comment.
We're losing the favicon here. Not sure if any of the other stuff below is important.
There was a problem hiding this comment.
I restored the previous tags and the favicon now points the correct path.
| We use caching to decrease the load on our servers (see <https://github.com/anuraghazra/github-readme-stats/issues/1471#issuecomment-1271551425>). Cards generated by [https://github-stats-extended.vercel.app/](https://github-stats-extended.vercel.app/frontend) are cached for a few hours or days, depending on server load. If you want the data on your cards to be updated more often you can [deploy your own instance](/frontend/docs/deploy/) and set [environment variable](/frontend/docs/deploy/#available-environment-variables) `CACHE_SECONDS` to a value of your choosing. Or you can use the [GitHub Action workflow](https://github.com/stats-organization/github-readme-stats-action). | ||
| We use caching to reduce the load on our servers (see [this discussion](https://github.com/anuraghazra/github-readme-stats/issues/1471#issuecomment-1271551425)). | ||
|
|
||
| Cards generated by [GitHub Stats Extended](https://github-stats-extended.vercel.app/frontend) are cached for a few hours to several days, depending on the current server load. |
There was a problem hiding this comment.
Cards generated by [GitHub Stats Extended]
The text should make it clear that the caching explanation only applies to our public deployment at github-stats-extended.vercel.app. Because self-hosted instances, the grs-action and using the npm package directly may behave differently.
There was a problem hiding this comment.
Updated (I haven't update the text here, it's written this way in master).
| We use caching to decrease the load on our servers (see <https://github.com/anuraghazra/github-readme-stats/issues/1471#issuecomment-1271551425>). Cards generated by [https://github-stats-extended.vercel.app/](https://github-stats-extended.vercel.app/frontend) are cached for a few hours or days, depending on server load. If you want the data on your cards to be updated more often you can [deploy your own instance](/frontend/docs/deploy/) and set [environment variable](/frontend/docs/deploy/#available-environment-variables) `CACHE_SECONDS` to a value of your choosing. Or you can use the [GitHub Action workflow](https://github.com/stats-organization/github-readme-stats-action). | ||
| We use caching to reduce the load on our servers (see [this discussion](https://github.com/anuraghazra/github-readme-stats/issues/1471#issuecomment-1271551425)). | ||
|
|
||
| Cards generated by [GitHub Stats Extended](https://github-stats-extended.vercel.app/frontend) are cached for a few hours to several days, depending on the current server load. |
There was a problem hiding this comment.
depending on the current server load
This sounds like we have a some dynamic logic in place for caching duration. In reality I have manually adapted the cache timing a few times over the past month.
There was a problem hiding this comment.
Adjusted the text (I haven't update the text here, it's written this way in master).
| ## Responsive Card Theme | ||
|
|
||
| [](https://github.com/stats-organization/github-stats-extended#responsive-card-theme#gh-dark-mode-only) | ||
| [](https://github.com/stats-organization/github-stats-extended#responsive-card-theme#gh-light-mode-only) |
There was a problem hiding this comment.
The theming via #gh-dark-mode-only/#gh-light-mode-only doesn't work here.
There was a problem hiding this comment.
The section header now uses <picture>, and the GitHub-only technique says why it has no live preview.
The copyable snippet is unchanged.
2b20bc5 to
24b8c19
Compare
24b8c19 to
bc40152
Compare


releaseinstead ofmaster#461apps/frontendinto an Astro + Starlight site.Serves the docs at
/frontend/docsand the card wizard at/frontend:one dev server, one build, one deploy, and no Python in
vercel-preparation.shor in the local setup.splashlayout,so it inherits the header, footer and search.
Its own app bar, theme picker and Redux theme slice go away.
Starlight writes the
data-themedaisyUI already reads, so one control themes both halves.*.mdsources move toapps/frontend/src/content/docs/docs/with atitleinfrontmatter and Starlight's
:::noteasides, which lets Astro resolve their links andimages natively (no markdown-conversion code of our own).
starlight-links-validatorthen fails the build on a dead internal link.packages/core/src/themes/README.mdis generated into the site instead; README and CONTRIBUTING links follow the move.index.cssdeclares the cascade-layer order(its utilities must outrank Starlight's reset) and scopes the app's element rules under
.wizard, leaving the site chrome identical on both halves.To try it out just run