Skip to content

[6.x] Remove dead fluid publish-fields CSS and unused selectedWidth computed - #15304

Merged
jasonvarga merged 2 commits into
6.xfrom
remove-fluid-publish-fields-css
Aug 28, 2026
Merged

[6.x] Remove dead fluid publish-fields CSS and unused selectedWidth computed#15304
jasonvarga merged 2 commits into
6.xfrom
remove-fluid-publish-fields-css

Conversation

@jasonvarga

@jasonvarga jasonvarga commented Aug 28, 2026

Copy link
Copy Markdown
Member

This clean up will be helpful in some upcoming changes regarding field widths and dashboard widget ui. #14690

  • .publish-fields-fluid (publish.css) was introduced in 07202fe133 for the old
    resources/js/components/publish/Fields.vue, applied broadly across the CP. That whole
    component tree was deleted in [6.x] Remove old components #11968 in favor of ui/Publish/Fields.vue, which never
    reintroduced the class. The one screen named in the class's own comment
    (/cp/collections/pages/edit, i.e. Configure Collection) now renders via asConfig() /
    a stacked divide-y layout instead — confirmed in CollectionsController::edit(). Dead
    since 2025-07-18.

  • .publish-fields-fluid--xl-only (publish.css) was added for the Blueprint Builder's
    Title/Hidden fields on 2025-09-01, then removed 5 weeks later in [6.x] Go back to v5 style config fields #12700 ("Go back to v5
    style config fields"), which replaced it with the same stacked as-config pattern. A
    deliberate UI-direction reversal, not an accidental casualty. Dead since 2025-10-09.

  • .publish-fields-fluid > * (animation.css) was added alongside the Blueprint Builder
    usage above and never removed when that markup changed. A later cleanup ([6.x] Kill sibling transitions #13658) touched
    a near-duplicate selector list elsewhere in the same file but missed this one — evidence
    nobody's relied on it since, not that it's still needed. The still-live .publish-fields > *
    selector in the same rule is untouched.

  • selectedWidth (resources/js/components/fields/Settings.vue) is an unused computed
    property. It's also broken dead code — it references this.widths, which isn't defined
    anywhere in that component, so it would throw if ever evaluated.

These are all internal implementation details that were never exposed as CP extension points
— no Blade view, config option, or documented customization hook ever emitted these classes,
and the computed was never referenced — so there's no addon-facing breaking-change risk.

@jasonvarga jasonvarga changed the title Remove dead fluid publish-fields CSS [6.x] Remove dead fluid publish-fields CSS Aug 28, 2026
@jasonvarga jasonvarga changed the title [6.x] Remove dead fluid publish-fields CSS [6.x] Remove dead fluid publish-fields CSS and JS helpers Aug 28, 2026
@jasonvarga
jasonvarga force-pushed the remove-fluid-publish-fields-css branch from 51eecc6 to 009d9e0 Compare August 28, 2026 20:24
@jasonvarga jasonvarga changed the title [6.x] Remove dead fluid publish-fields CSS and JS helpers [6.x] Remove dead fluid publish-fields CSS and unused selectedWidth computed Aug 28, 2026
@jasonvarga
jasonvarga merged commit 647e8f5 into 6.x Aug 28, 2026
66 checks passed
@jasonvarga
jasonvarga deleted the remove-fluid-publish-fields-css branch August 28, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant