[6.x] For links in tooltips, open them in a new tab if external - #15213
Open
jaygeorge wants to merge 2 commits into
Open
[6.x] For links in tooltips, open them in a new tab if external#15213jaygeorge wants to merge 2 commits into
jaygeorge wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
Tooltips in the CP include external links sometimes.
We discussed this internally and agreed that external tooltip links should open in a new tab
What this PR Does
Checks for external links in the tooltip and makes them
target="_blank"How to Reproduce
/cp/sites, where we're using them in hints likeLocale