Skip to content

[6.x] Forms 2: Temporary file upload fixes - #15206

Merged
duncanmcclean merged 2 commits into
forms-2from
forms-2-file-fixes
Aug 17, 2026
Merged

[6.x] Forms 2: Temporary file upload fixes#15206
duncanmcclean merged 2 commits into
forms-2from
forms-2-file-fixes

Conversation

@duncanmcclean

@duncanmcclean duncanmcclean commented Aug 17, 2026

Copy link
Copy Markdown
Member

This pull request fixes a couple of issues around form submissions' temporary file uploads.

  • Fixes an issue where emails would fail to send when an attached temporary file upload no longer exists on disk.
    • This was happening because temporary files can be cleaned up before a queued email is sent, and attaching a missing file throws an exception at send time.
    • This PR fixes it by skipping files that no longer exist.
  • Fixes an issue where deleting a submission would leave its temporary file uploads behind on disk.
    • This was happening because the DeleteTemporaryFiles job was only dispatched when finalizing a submission or when cleaning up abandoned partial submissions — deleting a submission from the Control Panel never triggered it.
    • This PR fixes it by dispatching the job from the submission's delete() method. Quiet deletes are excluded, since finalizing a submission on a non-storing form deletes it quietly before sending emails, which still need the files for attachments.

duncanmcclean and others added 2 commits August 17, 2026 17:57
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@duncanmcclean
duncanmcclean merged commit c0b4163 into forms-2 Aug 17, 2026
63 checks passed
@duncanmcclean
duncanmcclean deleted the forms-2-file-fixes branch August 17, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant