[6.x] Fix moved nav items reappearing after reordering children - #15198
Open
duncanmcclean wants to merge 1 commit into
Open
[6.x] Fix moved nav items reappearing after reordering children#15198duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
…children Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where a nav item moved out of its parent (like a collection moved to the top level of a section) would reappear under its original parent when the remaining children were reordered, resulting in the item being displayed twice. Clicking the moved item would also incorrectly highlight the original parent, since the resurrected child still matched the current URL. The same thing happened with hidden child items.
This was happening because when applying
@modifypreferences with reordered children,NavBuilderrebuilds the item's children from its original state — a snapshot taken before preferences are applied — which resurrects any children that earlier@moveor@hidepreferences had removed.This PR fixes it by keeping track of items removed from their parent's children while preferences are applied, and excluding them when children are rebuilt from the original state.
Fixes #10831