Skip to content

Fix #2462: counter column apiSupport reports filter:false #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erichare wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −2
Open

Fix #2462: counter column apiSupport reports filter:false #2513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/io/stargate/sgv2/jsonapi/service/schema/tables/ApiDataTypeDefs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ public abstract class ApiDataTypeDefs {
new PrimitiveApiDataTypeDef(
ApiTypeName.COUNTER,
DataTypes.COUNTER,
new ApiSupportDef.Support(false, false, true, true, ApiSupportDef.Update.NONE),
// counter values cannot be used in a filter (no CQL codec to bind them), so filter is
// false to match actual support, see #2462
new ApiSupportDef.Support(false, false, true, false, ApiSupportDef.Update.NONE),
// we do not support the user creating anything with a counter type, but we accept if the
// DB says
new DefaultTypeBindingRules(
Expand Down
21 changes: 20 additions & 1 deletion ...test/java/io/stargate/sgv2/jsonapi/api/v1/tables/UnsupportedTypeTableIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ public void canNotFilterOnFrozen() {

/**
* Data API support for counter column: CreateTable(False), Insert(false), Read(True),
* Filter(True)
* Filter(False)
*/
@Nested
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
Expand All @@ -161,6 +161,25 @@ public final void createDefaultTablesAndIndexes() {
assertThat(executeCqlStatement(createTable.build())).isTrue();
}

// Regression test for #2462: a counter column must report apiSupport.filter == false in the
// table description, because filtering on a counter is not actually supported (see
// filterCounter() below). Previously it incorrectly reported filter == true.
@Test
@Order(2)
public final void listTablesReportsCounterNotFilterable() {
var apiSupportPath =
"status.tables.find { it.name == '%s' }.definition.columns.counter.apiSupport"
.formatted(TABLE_COUNTER);
assertNamespaceCommand(keyspaceName)
.templated()
.listTables(true)
.wasSuccessful()
.body(apiSupportPath + ".createTable", is(false))

@amorton amorton Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fragile and encourages copy-past coding, we would create assertion functions for this

.body(apiSupportPath + ".insert", is(false))
.body(apiSupportPath + ".read", is(true))
.body(apiSupportPath + ".filter", is(false));
}

// In Cassandra, you cannot use an INSERT statement directly for counters.
// Instead, counter columns require a special kind of update operation.
// Counters in Cassandra are designed to increment or decrement a value,
Expand Down