Refactor for tests associated with Create Collection#2512
Open
amorton wants to merge 9 commits into
Open
Conversation
amorton
commented
Jun 17, 2026
| SchemaHolder<CollectionLexicalDef> lexicalDef, | ||
| SchemaHolder<CollectionRerankDef> rerankDef) | ||
| implements Operation<CollectionSchemaObject> { | ||
| public class CreateCollectionOperation implements Operation<KeyspaceSchemaObject> { |
Contributor
Author
There was a problem hiding this comment.
Moved from record to class, because it should never have been a record.
Contributor
📉 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📉 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
for the resolver and the operation getting it ready for changes to CreateCollectionOperation
@testprofile(NoGlobalResourcesTestProfile.Impl.class)
Contributor
📈 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Touches the tests for CreateCollectionCommandResolver and CreateCollectionOperation.
Refactor to improve test layout and coverage, without changing any of the classes under tests. So we are confident any issues are with the tests.
This PR will follow #2499 which laid the groundwork for improvements in CreateCollectionOperation. After merging this we can update the actual CreateCollectionOperation code to use the new SuprerShreddingBuilder for making statements and tests will be ready to be extended.
Which issue(s) this PR fixes:
Fixes #
Checklist