Replace Base with Stdlib and custom shims - #1655
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1655 +/- ##
==========================================
- Coverage 92.33% 92.28% -0.06%
==========================================
Files 67 69 +2
Lines 9953 10105 +152
==========================================
+ Hits 9190 9325 +135
- Misses 763 780 +17
🚀 New features to boost your workflow:
|
|
This PR is unfortunately quite large -- if it would be easier to review module-by-module I can try out the new stacked PRs feature, but there's also no real benefit to the project until the last commit actually removing Luckily almost all the changes are trivial, things like Let me know whichever would make your lives easier @nhuurre @SteveBronder |
53b59a6 to
29e783f
Compare
|
Ok, I don't intend to do any more history-rewriting on this branch pre-review at this point |
This PR is unfortunately quite large, but many of the changes are simple renames. Review should focus on the
src/std/folder and the few places where any non-trivial edits were made.This is the ultimate conclusion of the patch sequence #1643 #1644 #1650 #1652.
After updating to 5.5, Base was providing us (up to renaming) essentially just:
These are all easy to provide ourselves, which means we can remove the dependency entirely.
The binaries produced with
dune build --profile releasefrom this branch are 12mb, down from 15mb onmaster. Shockingly, they're also the same speed if not faster (especially when running optimizations):Javascript builds are down to 16mb from 19mb, with minified sizes roughly the same.
Submission Checklist
Release notes
Decreased our reliance on third-party packages
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)