Update module github.com/stacklok/toolhive-core to v0.0.23#5317
Update module github.com/stacklok/toolhive-core to v0.0.23#5317renovate[bot] wants to merge 3 commits into
Conversation
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5317 +/- ##
=======================================
Coverage 68.84% 68.84%
=======================================
Files 634 634
Lines 64433 64433
=======================================
+ Hits 44358 44361 +3
+ Misses 16795 16790 -5
- Partials 3280 3282 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
72f9966 to
4685ae5
Compare
4685ae5 to
7936c33
Compare
8e96bce to
4ebc871
Compare
4ebc871 to
e2e80e5
Compare
e2e80e5 to
1c91de3
Compare
1c91de3 to
82ead42
Compare
f1d6d86 to
c03c3af
Compare
The toolhive-core v0.0.22 bump adds a Stateless field to the registry server types. Regenerate the API docs so the committed swagger matches the generated output and the Verify Swagger Documentation check passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
There was a problem hiding this comment.
🚫 Please don't merge yet — this can't go green until an upstream library ships a fix. Requesting changes so it isn't merged by accident.
What's broken, in plain terms
Downloading a container image is like carrying boxes (the image's "layers") into a room one at a time. A new version of the go-containerregistry library added a rule: only 4 people can carry boxes at once, and each carrier must hand their badge back when they finish a box. But there's a bug — they never hand the badge back. After 4 boxes, everyone is holding a badge, nobody can grab one, and the line freezes forever.
ToolHive downloads every image this way, so any image with 5+ layers (like the time test server) freezes mid-download and never finishes. Our E2E Tests Core (proxy) job then waits and waits until the whole 15-minute run gives up — that's the red ❌ you keep seeing. (Smaller images, or ones already downloaded, have ≤4 boxes, so they're fine — which is why only this one test hangs.)
Why this PR triggers it
- This PR updates
toolhive-coreto v0.0.23. - v0.0.23 quietly pulls in the buggy library version —
go-containerregistryv0.21.6. - So this PR inherits the freeze. Nothing in the PR's own code is wrong.
The good news
The bug is already fixed upstream (google/go-containerregistry#2308 — "close the box, hand the badge back"). But that fix came out 3 days after the broken v0.21.6 was released, so there is no released version with the fix yet.
What to do
Wait for go-containerregistry to publish a new release (> v0.21.6) that includes the fix, then this PR will pass and can be merged. If we need toolhive-core v0.0.23 sooner, we can temporarily force the old, working library version (replace github.com/google/go-containerregistry => …@v0.21.5 in go.mod) — already tested and confirmed working — and remove it once the fixed release lands.
Heads-up: this freeze will hit any PR that pulls in go-containerregistry v0.21.6, not just this one.
This PR contains the following updates:
v0.0.21→v0.0.23Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
stacklok/toolhive-core (github.com/stacklok/toolhive-core)
v0.0.23Compare Source
What's Changed
Full Changelog: stacklok/toolhive-core@v0.0.22...v0.0.23
v0.0.22Compare Source
What's Changed
New Contributors
Full Changelog: stacklok/toolhive-core@v0.0.21...v0.0.22
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.