feat(ui): refresh application icon#643
Conversation
Documentation previewThe documentation preview has been deployed for this pull request. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93ecd99241
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1,95 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><title>rtp2httpd icon</title><defs><linearGradient id="bgGradient" x1="0%" x2="100%" y1="0%" y2="100%"><stop offset="0%" style="stop-color:#5b8def"/><stop offset="100%" style="stop-color:#8b5cf6"/></linearGradient></defs><rect width="128" height="128" x="0" y="0" fill="url(#bgGradient)" rx="24"/><g fill="none" stroke="#fff" stroke-linecap="round" stroke-width="8"><path d="M 18 42 L 48 42"/><path d="M 18 64 L 48 64"/><path d="M 18 86 L 48 86"/></g><path fill="#fff" stroke="#fff" stroke-linecap="round" stroke-linejoin="round" stroke-width="4" d="M 68 36 L 68 92 L 110 64 Z"/></svg> | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128" role="img" aria-labelledby="title"> | |||
There was a problem hiding this comment.
When this icon refresh is built into the daemon, /assets/icon.png is still served from src/embedded_web_data.h via embedded_web.c, but that generated header was not updated. I decompressed the embedded data__assets_icon_png array and it still matches the parent 5,575-byte PNG, while this commit's web-ui/public/assets/icon.png is 18,858 bytes, so CMake-built binaries continue serving the old icon; the release workflow also runs pnpm run web-ui:build and fails if src/embedded_web_data.h differs (.github/workflows/release.yaml:60-83).
Useful? React with 👍 / 👎.
1 participant
Summary
Refresh the application icon with a polished purple glass treatment while preserving the original streaming lines and play-button structure. The SVG remains the design source, with a new 1024×1024 RGBA master and a downsampled 128×128 runtime asset.
Impact
The README and documentation continue to consume the SVG directly. The player, status page, and package icon paths continue to use
web-ui/public/assets/icon.png, now rendered from the updated design.Validation
Validated the SVG with
xmllint, checked the staged diff withgit diff --check, and verified that both PNG files have the expected dimensions and alpha channel.