Remove branch protection for vwx releases#532
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the GitHub branch protection configuration by replacing the wildcard pattern stackhpc/[vwxy]* with the specific branch stackhpc/yoga across branches.tf, import_resources.py, and terraform.tfvars.json. The reviewer correctly pointed out that the comments explaining the wildcard matching logic in branches.tf are now obsolete and should be removed to keep the codebase clean.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This change adapts our old branch protection rules - matching stackhpc/[vwxy]* to instead only match stackhpc/yoga for two reasons: 1. Older releases (V/W/X) are no longer supported 2. branch protection rules with wildcard matching regularly breaks our automation. For example, stackhpc/yoga-community files matches the existing rules, and is a common branch name for our automation, which can then no longer be deleted. This is a common occurance when re-creating an existing automated PR.
Terraform Format and Style 🖌
|
This change adapts our old branch protection rules - matching stackhpc/[vwxy]* to instead only match stackhpc/yoga for two reasons: