Skip to content

Remove branch protection for vwx releases#532

Merged
Alex-Welsh merged 1 commit into
mainfrom
rm-vwx
Jun 4, 2026
Merged

Remove branch protection for vwx releases#532
Alex-Welsh merged 1 commit into
mainfrom
rm-vwx

Conversation

@Alex-Welsh
Copy link
Copy Markdown
Member

This change adapts our old branch protection rules - matching stackhpc/[vwxy]* to instead only match stackhpc/yoga for two reasons:

  1. Older releases (V/W/X) are no longer supported
  2. branch protection rules with wildcard matching regularly breaks our automation. For example, stackhpc/yoga-community files matches the existing rules, and is a common branch name for our automation, which can then no longer be deleted. This is a common occurance when re-creating an existing automated PR.

@Alex-Welsh Alex-Welsh requested a review from a team as a code owner June 4, 2026 12:34
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GitHub branch protection configuration by replacing the wildcard pattern stackhpc/[vwxy]* with the specific branch stackhpc/yoga across branches.tf, import_resources.py, and terraform.tfvars.json. The reviewer correctly pointed out that the comments explaining the wildcard matching logic in branches.tf are now obsolete and should be removed to keep the codebase clean.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread terraform/github/branches.tf
Comment thread terraform/github/branches.tf
This change adapts our old branch protection rules - matching stackhpc/[vwxy]*
to instead only match stackhpc/yoga for two reasons:

1. Older releases (V/W/X) are no longer supported
2. branch protection rules with wildcard matching regularly breaks our
   automation. For example, stackhpc/yoga-community files matches the
   existing rules, and is a common branch name for our automation, which
   can then no longer be deleted. This is a common occurance when
   re-creating an existing automated PR.
@stackhpc-ci
Copy link
Copy Markdown
Contributor

stackhpc-ci commented Jun 4, 2026

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output

Success! The configuration is valid.


Terraform Plan 📖success

Show Plan

undefined

Pusher: @Alex-Welsh, Action: pull_request, Working Directory: ``, Workflow: Terraform GitHub

@Alex-Welsh Alex-Welsh merged commit cade0c7 into main Jun 4, 2026
5 checks passed
@Alex-Welsh Alex-Welsh deleted the rm-vwx branch June 4, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants