feat: simplify RGW deployment docs#2335
Open
jackhodgkiss wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Cephadm configuration documentation to retrieve the Keystone admin password directly from passwords.yml and restructures the deployment instructions for RADOS Gateway load balancing. The review feedback highlights a typo ('discused'), suggests capitalizing 'Kolla' and adding periods in the newly added instructions, and points out an outdated paragraph that still references the removed password variable.
Alex-Welsh
reviewed
May 29, 2026
| - "config set client.rgw rgw_keystone_accepted_roles 'member, admin'" | ||
| - "config set client.rgw rgw_keystone_admin_domain Default" | ||
| - "config set client.rgw rgw_keystone_admin_password {{ secrets_ceph_rgw_keystone_password }}" | ||
| - "config set client.rgw rgw_keystone_admin_password {{ (lookup('file', kayobe_env_config_path ~ '/kolla/passwords.yml') | from_yaml).ceph_rgw_keystone_password }}" |
Remove the steps for copying `ceph_rgw_keystone_password` to `secrets.yml` with the use of a `lookup`. Also at the step for reconfiguring openstack services in both supported ingress sections. Signed-off-by: Jack Hodgkiss <jack@stackhpc.com>
jackhodgkiss
force-pushed
the
improve-ceph-rgw-docs
branch
from
e6dd9d8 to
c098e14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the steps for copying
ceph_rgw_keystone_passwordtosecrets.ymlwith the use of alookup. Also at the step for reconfiguring openstack services in both supported ingress sections.