Fix Amphora register playbook failing when using TLS#2162
Conversation
|
It would be nice to backport this to Caracal too. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request correctly addresses the TLS issue by introducing the openstack_cacert variable and applying it to the OpenStack modules. It also transitions the image renaming task to use the openstack.cloud.image module. However, the implementation of the rename task contains a logic error: by including the filename parameter, the module will attempt to upload the new image data to the old image ID because their checksums differ. This results in an unnecessary and incorrect data upload during what should be a simple rename operation. I have provided a suggestion to simplify this task.
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
CA certificate was not injected correctly for this playbook. Plus, using openstack.cloud.image Ansible module for renaming the existing old Amphora image.
seunghun1ee
force-pushed
the
fix-amphora-register
branch
from
c115157 to
9597d2a
Compare
|
Need more tests. Switch to draft. |
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
seunghun1ee
temporarily deployed
to
Leafcloud
GitHub Actions
Inactive
Alex-Welsh
added
waiting-author-response
|
Happy Friday @seunghun1ee, this is a friendly reminder that this PR is waiting for your changes or response. Please take a look when you have a moment! Note: Once your changes are ready, remove the |
2 participants
CA certificate was not injected correctly for this playbook.
Plus, using openstack.cloud.image Ansible module for renaming the existing old Amphora image.