Skip to content

fix: Application config takes precedence over Template - #745

Merged
sweb merged 4 commits into
mainfrom
fix/template-precedence
Aug 10, 2026
Merged

fix: Application config takes precedence over Template#745
sweb merged 4 commits into
mainfrom
fix/template-precedence

Conversation

@sweb

@sweb sweb commented Aug 10, 2026

Copy link
Copy Markdown
Member

Description

The precedence rules described in the documentation were not followed wrt Application and ApplicationTemplate. Also notes special treatment of jvmArgumentOverrides.

This is in a way breaking, because more specific values were swallowed before - fixing this can impact what's actually now executed.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sweb
sweb force-pushed the fix/template-precedence branch from 4f01a1e to d1a1362 Compare August 10, 2026 08:26
@sweb
sweb force-pushed the fix/template-precedence branch from d1a1362 to bc70e01 Compare August 10, 2026 08:55
@sweb
sweb marked this pull request as ready for review August 10, 2026 08:57
@sweb sweb moved this to Development: Waiting for Review in Stackable Engineering Aug 10, 2026
@razvan
razvan self-requested a review August 10, 2026 09:19
@razvan razvan moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 10, 2026
razvan
razvan previously approved these changes Aug 10, 2026

@razvan razvan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. the cli args are never used but the jvm prop fix is good.

remove double fixed header
razvan
razvan previously approved these changes Aug 10, 2026
delete empty line
@sweb
sweb added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit d221025 Aug 10, 2026
18 checks passed
@sweb
sweb deleted the fix/template-precedence branch August 10, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants