ci(template): Bump actions, add scheduled integration test #629
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| --- | ||
| name: Integration Test (Schedule) | ||
|
|
||
| on: | ||
| schedule: | ||
| # At 00:00 on Sunday. See: https://crontab.guru/#0_0_*_*_0 | ||
| - cron: "0 0 * * 0" | ||
|
Comment on lines
+6
to
+7
Member
There was a problem hiding this comment. I also wonder if we want to stagger these eventually. Less load on the image registry, etc... Wish there was a random delay option in Actions.
Member
There was a problem hiding this comment. One idea is that we can make the schedule daily. Then each operator can have a local file with the day(s) that it should run. The workflow can bail out early if $today doesn't match the file.
Member
Author
There was a problem hiding this comment. Yeah a
Member
There was a problem hiding this comment. Yeah makes sense. But I think staggering tests over different days would be better. If there are problems it gives developers some space to fix things without being overloaded at the start of the week. |
||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Run Integration Test | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| with: | ||
| persist-credentials: false | ||
| submodules: recursive | ||
|
|
||
| - name: Run Integration Test | ||
| id: test | ||
| if: github.event_name == 'schedule' | ||
| uses: stackabletech/actions/run-integration-test@b5cc0acc5287f6184551b77f3ae4a5c3e41678c4 # v0.17.3 | ||
| with: | ||
| replicated-api-token: ${{ secrets.REPLICATED_API_TOKEN }} | ||
| otlp-bearer-token: ${{ secrets.OTLP_BEARER_TOKEN }} | ||
| test-mode-input: schedule | ||
| test-mode: profile | ||
|
|
||
| - name: Send Notification | ||
| if: ${{ failure() || github.run_attempt > 1 }} | ||
| uses: stackabletech/actions/send-slack-notification@b5cc0acc5287f6184551b77f3ae4a5c3e41678c4 # v0.17.3 | ||
| with: | ||
| slack-token: ${{ secrets.SLACK_INTEGRATION_TEST_TOKEN }} | ||
| failed-tests: ${{ steps.test.outputs.failed-tests }} | ||
| test-health: ${{ steps.test.outputs.health }} | ||
| test-result: ${{ steps.test.conclusion }} | ||
| channel-id: C07UYJYSMSN # notifications-integration-tests | ||
| type: integration-test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, we should split this into a profile based workflow, and a kuttl based workflow (to set specific arguments like
--testand--parallel)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can still set
--testand--test-suitewith the current approach. Getting rid of interu for the dispatch would also get rid of a whole bunch of wiring (like which cluster to use, setting up env vars, etc).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point is the current list of inputs is kinda painful (and that's coming from me who knows how to use it).
I think others in the team will have similar complaints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One idea I had was a prek hook that can update a drop-down in the action so it always has selectable items. That would remove some friction.