Skip to content

feat: better startup and readiness probes - #976

Open
razvan wants to merge 13 commits into
mainfrom
worktree-nifi-2x-health-probes
Open

feat: better startup and readiness probes#976
razvan wants to merge 13 commits into
mainfrom
worktree-nifi-2x-health-probes

Conversation

@razvan

@razvan razvan commented Aug 10, 2026

Copy link
Copy Markdown
Member

Description

Fixes #946
Fixes #521

✅ Successfully tested on OKD.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@razvan razvan self-assigned this Aug 10, 2026
@razvan
razvan marked this pull request as ready for review August 10, 2026 15:41
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Aug 11, 2026
java.arg.11=-Dorg.apache.nifi.management.server.address=127.0.0.1:52020
java.arg.12=-Dhttps.proxyHost=proxy.my.corp
java.arg.13=-Djava.net.preferIPv4Stack=true
java.arg.14=-Xmx40000m

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be hard-coded (same further up)? I know it was, but seems like it shouldn't be.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a long chat with Claude on this topic and the conclusion was that this is the recommended way

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the IP address a constant here in case this is what you meant.

@razvan
razvan requested a review from NickLarsenNZ August 11, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

Improve startup- & readiness probes for NiFi 2.x Fix health-check to check actual health

2 participants