fix: Honour image.pullSecrets in the CSI provisioner Deployment - #417
Merged
Conversation
The Deployment read .Values.imagePullSecrets while the DaemonSet and values.yaml both use .Values.image.pullSecrets. Nothing defines imagePullSecrets, so the provisioner never received pull secrets: on a private registry the node driver starts and the provisioner fails to pull its image.
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
lfrancke
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CSI provisioner Deployment read
.Values.imagePullSecrets, while the node driver DaemonSet andvalues.yamlboth use.Values.image.pullSecrets.Looks like this was forgotten back in 2024 in #142.
I'd consider this a bug fix as the provisioner never received pull secrets this way.
Found while surveying the charts for values that templates read but
values.yamldoes not define.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker