feat(cli): first-run guide + guided wallet migration#45
Merged
Conversation
…tion Running `mir` with no args now prints a getting-started walkthrough (serve a machine / reach your machines / identity & backup / LAN-direct), with a one-time welcome banner when there's no config yet — instead of a single terse usage line. The first time a client command creates the owner identity it prints a one-line intro (your wallet address + how to back it up with the 24-word phrase). And a legacy (pre-wallet) identity running `mir attach`/`run`/`pair` now gets a clear, guided migration message — `mir keygen --wallet` mints a NEW identity so each machine must be re-paired — rather than a cryptic failure. Adds client.IdentityExists; tests for the guide and the migration hint. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the "first run is sparse" feedback + the confusing legacy-attach experience.
Changes
mirwith no args prints a friendly getting-started walkthrough(serve with
mir up/mir pair; reach withmir pair <code>/mir attach; identity &backup; LAN-direct note), with a one-time welcome banner when there's no config yet.
a one-line intro — your wallet address + "back it up with
mir wallet export-phrase".mir attach/run/pairnow gets a clear message:mir keygen --walletmints a new identity, so eachmachine must be re-paired — instead of a cryptic handshake/usage failure.
Tests
TestNoArgsShowsGuide,TestAttachLegacyIdentityGuidesToKeygen; full suite +go vet/gofmtgreen. Eyeballed all four paths (fresh guide, non-fresh guide, identity intro,legacy migration) on real binaries.
Ships in the v0.5.1 patch (with the already-merged SPA pbkdf2 fix).
🤖 Generated with Claude Code