Skip to content

Disable paging and raise pageSize on NinjaOne array-mode datastreams #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deenk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable paging and raise pageSize on NinjaOne array-mode datastreams #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions plugins/NinjaOne/v1/dataStreams/devices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,19 @@
"baseDataSourceName": "httpRequestUnscoped",
"config": {
"httpMethod": "get",
"paging": {
"mode": "token",
"pageSize": {
"realm": "queryArg",
"path": "pageSize",
"value": "1000"
},
"in": {
"realm": "payload",
"path": "metadata.next_page_token"
},
"out": {
"realm": "queryArg",
"path": "after"
}
"mode": "none"
},

Check failure on line 10 in plugins/NinjaOne/v1/dataStreams/devices.json

View check run for this annotation

Claude / Claude Code Review

Missing metadata.json version bump 

This PR modifies 6 data stream files under `plugins/NinjaOne/v1/dataStreams/` but does not bump the version in `plugins/NinjaOne/v1/metadata.json` (still at `1.1.9`). Per the repo's review guidance, any change inside a plugin directory must include a corresponding `metadata.json` version bump; since this is a behavior-affecting paging fix, please add at least a patch bump (e.g. `1.1.9` -> `1.1.10`) before merging.
Comment on lines 8 to 10
Copy link
Copy Markdown

@claude claude Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 This PR modifies 6 data stream files under plugins/NinjaOne/v1/dataStreams/ but does not bump the version in plugins/NinjaOne/v1/metadata.json (still at 1.1.9). Per the repo's review guidance, any change inside a plugin directory must include a corresponding metadata.json version bump; since this is a behavior-affecting paging fix, please add at least a patch bump (e.g. 1.1.9 -> 1.1.10) before merging.

Extended reasoning...

What the bug is

This PR changes runtime behavior of six NinjaOne data streams (devices.json, locationDevices.json, locations.json, organizationDevices.json, organizationLocations.json, organizations.json) by switching their paging mode from token to none and adding a pageSize: 10000 query arg. However, plugins/NinjaOne/v1/metadata.json is not modified by the PR and its version field still reads 1.1.9.

Why this matters

The repo's review instructions are explicit: "Any diff that touches files inside a plugin directory must include a corresponding change to metadata.json that increases the version field. If no version bump is present, assume the task is unfinished and prompt to add one." This is a hard rule, not a stylistic preference — without a version bump, downstream consumers cannot distinguish the fixed plugin from the broken pre-fix one, and the plugin distribution/release pipeline relies on the version field as its sole signal that the contents have changed.

Why existing checks don't catch it

The PR's automated Plugin PR Summary check reports Validation: ✅ Passed and Deployment: 🚀 Deployed, so the CI bot does not enforce the version-bump rule. The breaking-changes checkbox is set to "No", which is consistent with a patch bump (not a major/folder bump), but a patch bump is still required.

Impact

Once merged as-is, a user upgrading the plugin would receive the new paging behavior under an unchanged version number — making rollback decisions, support triage, and changelog tracking harder. Any downstream tooling keyed off the version (e.g. Has been updated since vX.Y.Z) will incorrectly report no change.

Step-by-step proof

  1. Open plugins/NinjaOne/v1/metadata.json on this branch — version is "1.1.9".
  2. Inspect the PR's changed-files list (6 files) — none of them is metadata.json.
  3. Inspect any of the six diffs (e.g. devices.json lines 8-10) — the paging block was rewritten from mode: token with pageSize/in/out to mode: none, and getArgs now carries pageSize: 10000. This is a clear behavior change.
  4. Per the repo guidance, this requires version to advance to at least 1.1.10. It has not.

How to fix

Bump plugins/NinjaOne/v1/metadata.json version from 1.1.9 to 1.1.10 (patch bump; no breaking change per the PR checkbox) and include it in this PR.

"expandInnerObjects": true,
"endpointPath": "/v2/devices",
"postRequestScript": "devices.js",
"pathToData": "",
"getArgs": [],
"getArgs": [
{
"key": "pageSize",
"value": "10000"
}
],
"headers": []
},
"metadata": [
Expand Down
22 changes: 7 additions & 15 deletions plugins/NinjaOne/v1/dataStreams/locationDevices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,18 @@
"config": {
"httpMethod": "get",
"paging": {
"mode": "token",
"pageSize": {
"realm": "queryArg",
"path": "pageSize",
"value": "1000"
},
"in": {
"realm": "payload",
"path": "metadata.next_page_token"
},
"out": {
"realm": "queryArg",
"path": "after"
}
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/v2/devices",
"postRequestScript": "locationDevices.js",
"pathToData": "",
"getArgs": [],
"getArgs": [
{
"key": "pageSize",
"value": "10000"
}
],
"headers": []
},
"matches": {
Expand Down
22 changes: 7 additions & 15 deletions plugins/NinjaOne/v1/dataStreams/locations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,18 @@
"config": {
"httpMethod": "get",
"paging": {
"mode": "token",
"pageSize": {
"realm": "queryArg",
"path": "pageSize",
"value": "1000"
},
"in": {
"realm": "payload",
"path": "metadata.next_page_token"
},
"out": {
"realm": "queryArg",
"path": "after"
}
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/v2/locations",
"postRequestScript": "locations.js",
"pathToData": "",
"getArgs": [],
"getArgs": [
{
"key": "pageSize",
"value": "10000"
}
],
"headers": []
},
"metadata": [
Expand Down
22 changes: 7 additions & 15 deletions plugins/NinjaOne/v1/dataStreams/organizationDevices.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,18 @@
"config": {
"httpMethod": "get",
"paging": {
"mode": "token",
"pageSize": {
"realm": "queryArg",
"path": "pageSize",
"value": "1000"
},
"in": {
"realm": "payload",
"path": "metadata.next_page_token"
},
"out": {
"realm": "queryArg",
"path": "after"
}
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/v2/organization/{{objects[0].organizationId}}/devices",
"postRequestScript": "devices.js",
"pathToData": "",
"getArgs": [],
"getArgs": [
{
"key": "pageSize",
"value": "10000"
}
],
"headers": []
},
"objectLimit": 1,
Expand Down
22 changes: 7 additions & 15 deletions plugins/NinjaOne/v1/dataStreams/organizationLocations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,26 +7,18 @@
"config": {
"httpMethod": "get",
"paging": {
"mode": "token",
"pageSize": {
"realm": "queryArg",
"path": "pageSize",
"value": "1000"
},
"in": {
"realm": "payload",
"path": "metadata.next_page_token"
},
"out": {
"realm": "queryArg",
"path": "after"
}
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/v2/locations",
"postRequestScript": "organizationLocations.js",
"pathToData": "",
"getArgs": [],
"getArgs": [
{
"key": "pageSize",
"value": "10000"
}
],
"headers": []
},
"matches": {
Expand Down
22 changes: 7 additions & 15 deletions plugins/NinjaOne/v1/dataStreams/organizations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,18 @@
"config": {
"httpMethod": "get",
"paging": {
"mode": "token",
"pageSize": {
"realm": "queryArg",
"path": "pageSize",
"value": "1000"
},
"in": {
"realm": "payload",
"path": "metadata.next_page_token"
},
"out": {
"realm": "queryArg",
"path": "after"
}
"mode": "none"
},
"expandInnerObjects": true,
"endpointPath": "/v2/organizations",
"postRequestScript": "organizations.js",
"pathToData": "",
"getArgs": [],
"getArgs": [
{
"key": "pageSize",
"value": "10000"
}
],
"headers": []
},
"metadata": [
Expand Down
Loading