fix(cluster): close S3 preflight runtime gate#61
Merged
Conversation
added 2 commits
July 18, 2026 12:04
Only require an exact PCM X grant when clustering is active and the buffer is tracked. Retained images and live ownership transitions remain fail-closed. Add behavior coverage for runtime-off, untracked, tracked, retained, and transition cases.
Expose retryable RESOURCE_RECOVERING image-fetch denials independently from master-not-holder retries and roll the gcs_recovery dump baseline.
sqlrush
force-pushed
the
fix/s3-preflight-runtime-gate
branch
from
July 18, 2026 04:09
c05be9c to
06d2446
Compare
Owner
Author
|
守门复审交接:
请按上一轮 F1/P3 finding 做最终复核;通过后将直接 merge,随后跑 main nightly。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConditionalLockBufferbehavior when PCM is inactive or a buffer is untrackedVerification
scripts/ci/check-format.sh: 580 files, 0 violationsmake -C src/test/cluster_unit check: 182/182 binariesThis is the final code-side preflight hotfix before nightly, t/400, and the S3 two-leg run.