fix(cluster): close S3 preflight coherence gaps#60
Merged
Conversation
added 3 commits
July 18, 2026 11:26
The production registry and t/015 already report 183 injection points. Align the four layout TAP baselines so the full nightly shard no longer fails on the stale 181 snapshot.
Require an exact unencumbered local X image before ConditionalLockBuffer can expose write authority. Reuse the nested held-content-lock guard before holder retry sleeps so a frozen foreign holder cannot deadlock RETIRE.
Treat DENIED_RESOURCE_RECOVERING as transient source authority inside the existing bounded image-fetch retry budget. Keep fail-closed byte validation restricted to putative READ_IMAGE replies.
Owner
Author
|
Guardkeeper handoff (S3 preflight):
Codex does not operate the VM; please report the install identity and t/400/S3 evidence here or through the existing guardkeeper channel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
ConditionalLockBuffercan return write authorityDENIED_RESOURCE_RECOVERINGinside the bounded PCM-X image-fetch budget instead of misclassifying it as corrupt image bytesHow it was tested
macOS, local cluster-enabled build:
make -C src/backend/storage/buffer bufmgr.omake -C src/backend/cluster cluster_gcs_block.oCLANG_FORMAT=/opt/homebrew/opt/llvm@18/bin/clang-format scripts/ci/check-format.sh— 580 files, 0 violationsmake -C src/test/cluster_unit check— all 182 binaries passedmake -C src/test/cluster_tap check PROVE_TESTS="t/020_shmem_registry.pl t/021_block_format.pl t/022_itl_slot.pl t/023_buffer_descriptor.pl"— 4 files / 83 tests passedThe F1, F2, and image-fetch source-contract tests were each observed RED before the production fix and GREEN afterward.
Checklist
bufmgr.cbehavior change remains underUSE_PGRAC_CLUSTER.Assert()-only checks.