fix: pass nil tags when task definition has no tags#44
Merged
Conversation
alexbell708
approved these changes
Jun 24, 2026
AWS rejects RegisterTaskDefinition with an empty Tags slice ("Tags can
not be empty"). #43 passed describeResult.Tags directly, which is an
empty slice for untagged task definitions rather than nil. The SDK
treats nil (omit the field) and []Tag{} (empty list) differently.
Add nilIfEmpty() helper that converts an empty slice to nil so untagged
task definitions continue to work, while tagged task definitions still
propagate their tags correctly.
teaguru
force-pushed
the
fix/empty-tags-register-task-definition
branch
from
8809160 to
4ba9096
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS rejects RegisterTaskDefinition with an empty Tags slice ("Tags can not be empty"). #43 passed describeResult.Tags directly, which is an empty slice for untagged task definitions rather than nil. The SDK treats nil (omit the field) and []Tag{} (empty list) differently.
Add nilIfEmpty() helper that converts an empty slice to nil so untagged task definitions continue to work, while tagged task definitions still propagate their tags correctly.