Fix AOT generated GreaterThanEqual derived query - #2371
Open
adityaanikam wants to merge 1 commit into
Open
Conversation
JdbcCodeBlocks emitted Criteria.greaterThanEquals(...) for the GTE comparator, a method that does not exist on Criteria; the correct method is greaterThanOrEquals(...), used directly above it for LTE. Since AOT processing generates a repository's whole fragment as a single Java class, this one bad call broke compilation of the entire generated class, not just the affected query method. Confirmed by temporarily reverting the fix: all 38 tests in JdbcRepositoryContributorIntegrationTests failed, not only the new one added here. Added findAllByAgeGreaterThanEqual to UserRepository and a matching integration test that exercises the generated fragment against a real H2 database. Closes spring-projects#2365 Signed-off-by: Aditya Nikam <adityanikam9502@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2365
JdbcCodeBlocks emitted Criteria.greaterThanEquals(...) for the GTE comparator, a method that does not exist on Criteria. The correct method is greaterThanOrEquals(...), used directly above it for the LTE comparator.
Since AOT processing generates a repository's whole fragment as a single Java class, this one bad call broke compilation of the entire generated class, not just the affected query method. I confirmed this by temporarily reverting the fix locally: all 38 tests in JdbcRepositoryContributorIntegrationTests failed, not only a test targeting GreaterThanEqual specifically.
Added findAllByAgeGreaterThanEqual to the UserRepository test fixture and a matching integration test that exercises the generated fragment against a real H2 database, run with mvn test.