Use configured JsonMapper bean when resolving JacksonJsonSerde - #3243
Open
adityaanikam wants to merge 1 commit into
Open
Use configured JsonMapper bean when resolving JacksonJsonSerde#3243adityaanikam wants to merge 1 commit into
adityaanikam wants to merge 1 commit into
Conversation
Fixes spring-cloudgh-3231 Signed-off-by: adityaanikam <adityanikam9502@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-3231
What / why
SerdeResolverUtils.resolveForType()falls back tonew JacksonJsonSerde<>(genericRawClazz)(the no-arg-mapper constructor) whenever no matchingSerdebean and no valid fallback are found. This means anyJsonMapperbean configured in the application context — forspring.jackson.*customization or otherwise — is never picked up for Serdes created through this path, even thoughJacksonJsonSerdehas a(Class, JsonMapper)constructor that supports exactly this.Fix
Look up a
JsonMapperbean from the context (context.getBeanProvider(JsonMapper.class).getIfUnique()) and pass it intoJacksonJsonSerde's constructor when exactly one unambiguous bean is present, falling back to today's no-arg behavior otherwise (zero or multiple candidates).Testing
Added
SerdeResolverUtilsTests.ResolveForType.NoMatchingSerdeBeans.WithJsonMapperBean, which registers a customJsonMapperbean and verifies (via theJacksonJsonSerializerinternal field) that the exact same instance is wired into the resolved Serde. Ran the fullspring-cloud-stream-binder-kafka-streamstest suite locally (122 tests, 0 failures, 0 errors) to confirm no regressions.