refactor: fix FieldMayBeFinal warnings across modules

spring-cloud-function-adapters/spring-cloud-function-adapter-aws/src/main/java/org/springframework/cloud/function/adapter/aws/AWSLambdaUtils.java

@@ -46,11 +46,12 @@
  *
  * @author Oleg Zhurakousky
  * @author Anton Barkan
+ * @author Roman Akentev
  *
  */
 public final class AWSLambdaUtils {
 
-	private static Log logger = LogFactory.getLog(AWSLambdaUtils.class);
+	private static final Log logger = LogFactory.getLog(AWSLambdaUtils.class);
 
 	static final String AWS_API_GATEWAY = "aws-api-gateway";
 

spring-cloud-function-adapters/spring-cloud-function-adapter-aws/src/main/java/org/springframework/cloud/function/adapter/aws/CustomRuntimeEventLoop.java

@@ -66,7 +66,7 @@
  */
 public final class CustomRuntimeEventLoop implements SmartLifecycle {
 
-	private static Log logger = LogFactory.getLog(CustomRuntimeEventLoop.class);
+	private static final Log logger = LogFactory.getLog(CustomRuntimeEventLoop.class);
 
 	static final String LAMBDA_VERSION_DATE = "2018-06-01";
 	private static final String LAMBDA_ERROR_URL_TEMPLATE = "http://{0}/{1}/runtime/invocation/{2}/error";
@@ -81,7 +81,7 @@ public final class CustomRuntimeEventLoop implements SmartLifecycle {
 
 	private volatile boolean running;
 
-	private ExecutorService executor = Executors.newSingleThreadExecutor();
+	private final ExecutorService executor = Executors.newSingleThreadExecutor();
 
 	private FunctionInvocationWrapper routingFunction;
 

spring-cloud-function-adapters/spring-cloud-function-adapter-aws/src/main/java/org/springframework/cloud/function/adapter/aws/CustomRuntimeInitializer.java

@@ -28,10 +28,11 @@
 /**
  * @author Dave Syer
  * @author Oleg Zhurakousky
+ * @author Roman Akentev
  */
 public class CustomRuntimeInitializer implements ApplicationContextInitializer<GenericApplicationContext> {
 
-	private static Log logger = LogFactory.getLog(CustomRuntimeInitializer.class);
+	private static final Log logger = LogFactory.getLog(CustomRuntimeInitializer.class);
 
 	@Override
 	public void initialize(GenericApplicationContext context) {

spring-cloud-function-adapters/spring-cloud-function-adapter-aws/src/main/java/org/springframework/cloud/function/adapter/aws/FunctionInvoker.java

@@ -48,14 +48,15 @@
 /**
  *
  * @author Oleg Zhurakousky
+ * @author Roman Akentev
  * @since 3.1
  *
  *        see
  *        https://docs.aws.amazon.com/apigateway/latest/developerguide/set-up-lambda-proxy-integrations.html#api-gateway-simple-proxy-for-lambda-output-format
  */
 public class FunctionInvoker implements RequestStreamHandler {
 
-	private static Log logger = LogFactory.getLog(FunctionInvoker.class);
+	private static final Log logger = LogFactory.getLog(FunctionInvoker.class);
 
 	private JsonMapper jsonMapper;
 

spring-cloud-function-adapters/spring-cloud-function-adapter-aws/src/main/java/org/springframework/cloud/function/adapter/aws/LambdaDestinationResolver.java

@@ -31,11 +31,12 @@
  *
  * @author Dave Syer
  * @author Oleg Zhurakousky
+ * @author Roman Akentev
  *
  */
 public class LambdaDestinationResolver implements DestinationResolver {
 
-	private static Log logger = LogFactory.getLog(LambdaDestinationResolver.class);
+	private static final Log logger = LogFactory.getLog(LambdaDestinationResolver.class);
 
 	@Override
 	public String destination(Supplier<?> supplier, String name, Object value) {

spring-cloud-function-adapters/spring-cloud-function-adapter-aws/src/test/java/org/springframework/cloud/function/adapter/aws/CustomRuntimeEventLoopTest.java

@@ -37,10 +37,11 @@
 /**
  *
  * @author Oleg Zhurakousky
+ * @author Roman Akentev
  */
 public class CustomRuntimeEventLoopTest {
 
-	private String API_EVENT = "{\n"
+	private final String API_EVENT = "{\n"
 			+ "    \"version\": \"1.0\",\n"
 			+ "    \"resource\": \"$default\",\n"
 			+ "    \"path\": \"/question\",\n"

spring-cloud-function-adapters/spring-cloud-function-adapter-azure-web/src/test/java/org/springframework/cloud/function/adapter/azure/web/AzureWebProxyInvokerTests.java

@@ -121,7 +121,7 @@ public Builder createResponseBuilder(HttpStatus status) {
 	public static class BuilderStub implements Builder {
 
 		private HttpStatusType status;
-		private Map<String, String> headers = new HashMap<>();
+		private final Map<String, String> headers = new HashMap<>();
 		private Object body;
 
 		@Override
@@ -151,9 +151,9 @@ public HttpResponseMessage build() {
 
 	public static class HttpResponseMessageStub implements HttpResponseMessage {
 
-		private HttpStatusType status;
-		private Map<String, String> headers = new HashMap<>();
-		private Object body;
+		private final HttpStatusType status;
+		private final Map<String, String> headers;
+		private final Object body;
 
 		HttpResponseMessageStub(HttpStatusType status, Map<String, String> headers,
 				Object body) {

spring-cloud-function-adapters/spring-cloud-function-adapter-azure-web/src/test/java/org/springframework/cloud/function/adapter/azure/web/PetData.java

@@ -28,81 +28,81 @@ public final class PetData {
 	private PetData() {
 
 	}
-	private static List<String> breeds = new ArrayList<>();
+	private static final List<String> BREEDS = new ArrayList<>();
 	static {
-		breeds.add("Afghan Hound");
-		breeds.add("Beagle");
-		breeds.add("Bernese Mountain Dog");
-		breeds.add("Bloodhound");
-		breeds.add("Dalmatian");
-		breeds.add("Jack Russell Terrier");
-		breeds.add("Norwegian Elkhound");
+		BREEDS.add("Afghan Hound");
+		BREEDS.add("Beagle");
+		BREEDS.add("Bernese Mountain Dog");
+		BREEDS.add("Bloodhound");
+		BREEDS.add("Dalmatian");
+		BREEDS.add("Jack Russell Terrier");
+		BREEDS.add("Norwegian Elkhound");
 	}
 
-	private static List<String> names = new ArrayList<>();
+	private static final List<String> NAMES = new ArrayList<>();
 	static {
-		names.add("Bailey");
-		names.add("Bella");
-		names.add("Max");
-		names.add("Lucy");
-		names.add("Charlie");
-		names.add("Molly");
-		names.add("Buddy");
-		names.add("Daisy");
-		names.add("Rocky");
-		names.add("Maggie");
-		names.add("Jake");
-		names.add("Sophie");
-		names.add("Jack");
-		names.add("Sadie");
-		names.add("Toby");
-		names.add("Chloe");
-		names.add("Cody");
-		names.add("Bailey");
-		names.add("Buster");
-		names.add("Lola");
-		names.add("Duke");
-		names.add("Zoe");
-		names.add("Cooper");
-		names.add("Abby");
-		names.add("Riley");
-		names.add("Ginger");
-		names.add("Harley");
-		names.add("Roxy");
-		names.add("Bear");
-		names.add("Gracie");
-		names.add("Tucker");
-		names.add("Coco");
-		names.add("Murphy");
-		names.add("Sasha");
-		names.add("Lucky");
-		names.add("Lily");
-		names.add("Oliver");
-		names.add("Angel");
-		names.add("Sam");
-		names.add("Princess");
-		names.add("Oscar");
-		names.add("Emma");
-		names.add("Teddy");
-		names.add("Annie");
-		names.add("Winston");
-		names.add("Rosie");
+		NAMES.add("Bailey");
+		NAMES.add("Bella");
+		NAMES.add("Max");
+		NAMES.add("Lucy");
+		NAMES.add("Charlie");
+		NAMES.add("Molly");
+		NAMES.add("Buddy");
+		NAMES.add("Daisy");
+		NAMES.add("Rocky");
+		NAMES.add("Maggie");
+		NAMES.add("Jake");
+		NAMES.add("Sophie");
+		NAMES.add("Jack");
+		NAMES.add("Sadie");
+		NAMES.add("Toby");
+		NAMES.add("Chloe");
+		NAMES.add("Cody");
+		NAMES.add("Bailey");
+		NAMES.add("Buster");
+		NAMES.add("Lola");
+		NAMES.add("Duke");
+		NAMES.add("Zoe");
+		NAMES.add("Cooper");
+		NAMES.add("Abby");
+		NAMES.add("Riley");
+		NAMES.add("Ginger");
+		NAMES.add("Harley");
+		NAMES.add("Roxy");
+		NAMES.add("Bear");
+		NAMES.add("Gracie");
+		NAMES.add("Tucker");
+		NAMES.add("Coco");
+		NAMES.add("Murphy");
+		NAMES.add("Sasha");
+		NAMES.add("Lucky");
+		NAMES.add("Lily");
+		NAMES.add("Oliver");
+		NAMES.add("Angel");
+		NAMES.add("Sam");
+		NAMES.add("Princess");
+		NAMES.add("Oscar");
+		NAMES.add("Emma");
+		NAMES.add("Teddy");
+		NAMES.add("Annie");
+		NAMES.add("Winston");
+		NAMES.add("Rosie");
 	}
 
 	public static List<String> getBreeds() {
-		return breeds;
+		return BREEDS;
 	}
 
 	public static List<String> getNames() {
-		return names;
+		return NAMES;
 	}
 
 	public static String getRandomBreed() {
-		return breeds.get(ThreadLocalRandom.current().nextInt(0, breeds.size() - 1));
+		return BREEDS.get(ThreadLocalRandom.current().nextInt(0, BREEDS.size() - 1));
 	}
 
 	public static String getRandomName() {
-		return names.get(ThreadLocalRandom.current().nextInt(0, names.size() - 1));
+		return NAMES.get(ThreadLocalRandom.current().nextInt(0, NAMES.size() - 1));
 	}
 
 	public static Date getRandomDoB() {

spring-cloud-function-adapters/spring-cloud-function-adapter-azure-web/src/test/java/org/springframework/cloud/function/adapter/azure/web/TestExecutionContext.java

@@ -23,7 +23,7 @@
 
 public class TestExecutionContext implements ExecutionContext {
 
-	private String name;
+	private final String name;
 
 	public TestExecutionContext(String name) {
 		this.name = name;

spring-cloud-function-adapters/spring-cloud-function-adapter-azure/src/main/java/org/springframework/cloud/function/adapter/azure/AzureFunctionInstanceInjector.java

@@ -38,11 +38,12 @@
  * creation to this instance factory.
  * @author Christian Tzolov
  * @author Omer Celik
+ * @author Roman Akentev
  * @since 3.2.9
  */
 public class AzureFunctionInstanceInjector implements FunctionInstanceInjector {
 
-	private static Log logger = LogFactory.getLog(AzureFunctionInstanceInjector.class);
+	private static final Log logger = LogFactory.getLog(AzureFunctionInstanceInjector.class);
 
 	private static ConfigurableApplicationContext APPLICATION_CONTEXT;
 

spring-cloud-function-adapters/spring-cloud-function-adapter-azure/src/test/java/org/springframework/cloud/function/adapter/azure/helper/BuilderStub.java

@@ -26,7 +26,7 @@
 public class BuilderStub implements Builder {
 
 	private HttpStatusType status;
-	private Map<String, String> headers = new HashMap<>();
+	private final Map<String, String> headers = new HashMap<>();
 	private Object body;
 
 	@Override

spring-cloud-function-adapters/spring-cloud-function-adapter-azure/src/test/java/org/springframework/cloud/function/adapter/azure/helper/HttpResponseMessageStub.java

@@ -16,17 +16,16 @@
 
 package org.springframework.cloud.function.adapter.azure.helper;
 
-import java.util.HashMap;
 import java.util.Map;
 
 import com.microsoft.azure.functions.HttpResponseMessage;
 import com.microsoft.azure.functions.HttpStatusType;
 
 public class HttpResponseMessageStub implements HttpResponseMessage {
 
-	private HttpStatusType status;
-	private Map<String, String> headers = new HashMap<>();
-	private Object body;
+	private final HttpStatusType status;
+	private final Map<String, String> headers;
+	private final Object body;
 
 	public HttpResponseMessageStub(HttpStatusType status, Map<String, String> headers,
 			Object body) {

spring-cloud-function-adapters/spring-cloud-function-adapter-azure/src/test/java/org/springframework/cloud/function/adapter/azure/helper/TestExecutionContext.java

@@ -23,7 +23,7 @@
 
 public class TestExecutionContext implements ExecutionContext {
 
-	private String name;
+	private final String name;
 
 	public TestExecutionContext(String name) {
 		this.name = name;

spring-cloud-function-adapters/spring-cloud-function-grpc-cloudevent-ext/src/main/java/org/springframework/cloud/function/grpc/ce/CloudEventHandler.java

@@ -27,13 +27,14 @@
 /**
  *
  * @author Oleg Zhurakousky
+ * @author Roman Akentev
  * @since 3.2
  *
  */
 @SuppressWarnings("rawtypes")
 class CloudEventHandler extends CloudEventServiceImplBase  {
 
-	private Log logger = LogFactory.getLog(CloudEventHandler.class);
+	private final Log logger = LogFactory.getLog(CloudEventHandler.class);
 
 	private final MessageHandlingHelper helper;
 

spring-cloud-function-adapters/spring-cloud-function-grpc/src/main/java/org/springframework/cloud/function/grpc/GrpcServer.java

@@ -39,13 +39,14 @@
  * @author Oleg Zhurakousky
  * @author Dave Syer
  * @author Chris Bono
+ * @author Roman Akentev
  *
  * @since 3.2
  *
  */
 class GrpcServer implements SmartLifecycle, EnvironmentAware {
 
-	private Log logger = LogFactory.getLog(GrpcServer.class);
+	private final Log logger = LogFactory.getLog(GrpcServer.class);
 
 	private final FunctionGrpcProperties grpcProperties;
 

spring-cloud-function-adapters/spring-cloud-function-grpc/src/main/java/org/springframework/cloud/function/grpc/GrpcUtils.java

@@ -49,7 +49,7 @@
  */
 public final class GrpcUtils {
 
-	private static Log logger = LogFactory.getLog(GrpcUtils.class);
+	private static final Log logger = LogFactory.getLog(GrpcUtils.class);
 
 	private GrpcUtils() {
 

spring-cloud-function-adapters/spring-cloud-function-grpc/src/main/java/org/springframework/cloud/function/grpc/MessageHandlingHelper.java

@@ -50,11 +50,12 @@
 /**
  *
  * @author Oleg Zhurakousky
+ * @author Roman Akentev
  * @since 3.2
  */
 public class MessageHandlingHelper<T extends GeneratedMessageV3> implements SmartLifecycle {
 
-	private Log logger = LogFactory.getLog(MessageHandlingHelper.class);
+	private final Log logger = LogFactory.getLog(MessageHandlingHelper.class);
 
 	private final List<GrpcMessageConverter<?>> grpcConverters;
 

spring-cloud-function-adapters/spring-cloud-function-serverless-web/src/main/java/org/springframework/cloud/function/serverless/web/ServerlessHttpServletResponse.java

@@ -48,14 +48,15 @@
 /**
  *
  * @author Oleg Zhurakousky
+ * @author Roman Akentev
  * @since 4.x
  *
  */
 public class ServerlessHttpServletResponse implements HttpServletResponse {
 
 	private static final String DATE_FORMAT = "EEE, dd MMM yyyy HH:mm:ss zzz";
 
-	private String defaultCharacterEncoding = WebUtils.DEFAULT_CHARACTER_ENCODING;
+	private final String defaultCharacterEncoding = WebUtils.DEFAULT_CHARACTER_ENCODING;
 
 	private String characterEncoding = this.defaultCharacterEncoding;