fix(gcp): register nested URL protocol handler in GcfJarLauncher - #1434
Open
akenra wants to merge 1 commit into
Open
fix(gcp): register nested URL protocol handler in GcfJarLauncher#1434akenra wants to merge 1 commit into
akenra wants to merge 1 commit into
Conversation
GcfJarLauncher's constructor bypasses Launcher.launch() and creates a LaunchedClassLoader directly. Unlike Launcher.launch(), the constructor never called Handlers.register(), which meant the JVM could not resolve nested: URLs. When JarUrlClassLoader tried to resolve BOOT-INF/lib/ entries it threw java.net.MalformedURLException: unknown protocol: nested. Replace the commented-out JarFile.registerUrlProtocolHandler() (which registered the jar: protocol in Spring Boot 2.x) with Handlers.register(), the Boot 4.x equivalent that registers the nested: protocol handler. Fixes spring-cloudgh-1336 Signed-off-by: akenra <37288280+akenra@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi, @olegz!
I decided to try and fix this issue due to popular demand.
As far as I can tell, GcfJarLauncher's constructor bypasses Launcher.launch() and creates a LaunchedClassLoader directly. Unlike Launcher.launch(), the constructor never called Handlers.register(), which meant the JVM could not resolve nested: URLs. When JarUrlClassLoader tried to resolve BOOT-INF/lib/ entries it threw java.net.MalformedURLException: unknown protocol: nested.
So I replaced the commented-out JarFile.registerUrlProtocolHandler() (which registered the jar: protocol in Spring Boot 2.x) with Handlers.register(), the Boot 4.x equivalent that registers the nested: protocol handler.
Fixes gh-1336