fix(aws): align Custom Runtime error format with Lambda Runtime - #1433
Closed
akenra wants to merge 1 commit into
Closed
fix(aws): align Custom Runtime error format with Lambda Runtime#1433akenra wants to merge 1 commit into
akenra wants to merge 1 commit into
Conversation
Change errorType to fully qualified class name and stackTrace to JSON array of strings to match the standard Lambda Runtime format. Also add the Lambda-Runtime-Function-Error-Type header. Fixes spring-cloudgh-1428 Signed-off-by: akenra <37288280+akenra@users.noreply.github.com>
Contributor
|
Hey, @akenra i just saw this, sorry. I'll revert my commit and accept your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @olegz!
Since I'm on a bit of a contribution spree, I've decided to try my hand at @mrjv's proposal.
The solution seems rather simple: we need to change the
errorTypeto a fully qualified class name andstackTraceto JSON array of strings to match the standard Lambda Runtime format. I added the "Lambda-Runtime-Function-Error-Type" HTTP header as well since AWS Lambda Runtime API seems to use it.Fixes gh-1428