refactor(context): clean up ContextFunctionCatalogAutoConfiguration - #1431
Open
akenra wants to merge 1 commit into
Open
refactor(context): clean up ContextFunctionCatalogAutoConfiguration#1431akenra wants to merge 1 commit into
akenra wants to merge 1 commit into
Conversation
Addresses spring-cloud#1421 requested cleanups: - Make logger private static final - Inject FunctionProperties as a bean parameter in functionCatalog() instead of calling context.getBean() - Cleanup unnecessary initializations Additional improvements: - Use wildcard MapperBuilder<?, ?> to fix unsafe raw type usage and clean up builder chaining - Log detailed warning when ObjectMapper context lookup or .rebuild() fails before falling back to default builder - Log warning on Gson context lookup failure prior to default fallback - Make Kotlin module reflection type-safe via ClassUtils.forName(), isAssignableFrom(), and asSubclass(), adding warning logs for missing/incompatible modules - Modernize casting using Java 17 pattern matching for ConversionService, CompositeMessageConverter, and CloudEventsFunctionInvocationHelper - Simplify StringMessageConverter ContentTypeResolver to a null-safe lambda - Explicitly pass ClassUtils.getDefaultClassLoader() to ClassUtils.isPresent() checks - Fix typo in JsonMapper exception message ("claspath" -> "classpath") Fixes spring-cloud#1421 Signed-off-by: akenra <37288280+akenra@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @olegz!
This PR addresses the cleanup requested in #1421 along with a few error-handling and typing improvements in ContextFunctionCatalogAutoConfiguration.
A few details on what's inside:
Let me know if anything needs adjustments!
Fixes #1421