fix: run full Splunk matrix on PR/push to release/* branches (ADDON-88928)#523
Conversation
…8928) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2860ce3e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [[ "${{ startsWith(github.base_ref, 'release/') }}" == "true" ]] || \ | ||
| [[ "${{ startsWith(github.ref_name, 'release/') }}" == "true" && "${{ github.event_name }}" == "push" && "${{ inputs.execute-tests-on-push-to-release }}" == "true" ]]; then |
There was a problem hiding this comment.
When a caller sets wfe-run-on-splunk-latest: "true" to keep WFE tests on latest Splunk, a PR with github.base_ref matching release/* or an enabled push to release/* now enters these new clauses and unconditionally resets wfe_run_on_splunk_latest to false. That makes release runs always use the full supported matrix despite the workflow input's documented force/override semantics, so backport or emergency release workflows cannot opt into the smaller matrix.
Useful? React with 👍 / 👎.
|
Validation run confirming full Splunk matrix on release/* base: https://github.com/splunk/test-addonfactory-repo/actions/runs/29605345265 |
1 participant
Summary
ADDON-88928: PR/push targeting
release/*branches was running Splunk tests against latest-Splunk-only instead of the full supported matrix. Themetajob'sdetermine_splunkstep only special-casedmain/develop, sorelease/*fell into the latest-onlyelsebranch — exactly where full-matrix coverage matters most before cutting a release.Change
reusable-build-test-release.yml: extend thedetermine_splunkcondition to also treatrelease/*as full-matrix — for PR (base_ref) and for push (ref_name, gated byexecute-tests-on-push-to-releaseto match the existing push gate).README.md: document therelease/*full-matrix behavior.Validated (test-addonfactory-repo)
release/*base (test-addonfactory-repo#376):metajob succeeded; the job-summary consumed the full 5-version matrix[10.2.5, 10.0.8, 9.4.13, 9.3.14, 10.4.1]instead of latest-only[10.4.1]. AC confirmed.@developreproduced a pre-existingstartup_failure(missingGH_TOKEN_ADMINpassthrough in the caller), proving the failure was environmental and independent of this change; adding the passthrough unblocked the run.JIRA: https://splunk.atlassian.net/browse/ADDON-88928