Skip to content

chore: migrate publish job from PAT to GitHub App authentication #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbruzda-splunk wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: migrate publish job from PAT to GitHub App authentication #521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/reusable-build-test-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,6 @@ on:
type: string
default: "[]"
secrets:
GH_TOKEN_ADMIN:
description: Github admin token
required: true
GH_APP_CLIENT_ID:
Comment on lines 85 to 86

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Retain the deprecated secret during the migration

Existing callers that were valid against the previous workflow_call contract must explicitly pass GH_TOKEN_ADMIN, because it was required; once this declaration is removed, GitHub rejects those callers with an undefined-secret workflow validation error before any job runs. This repository documents that workflow updates are automatically applied to consumer repositories (README.md:177), but this commit cannot update their secrets: blocks, so publishing and all other workflow execution will break until every consumer changes in lockstep. Keep GH_TOKEN_ADMIN declared as optional (while leaving it unused) for a compatibility window.

Useful? React with 👍 / 👎.

description: GitHub App Client ID for authentication
required: true
Expand Down Expand Up @@ -3495,6 +3492,13 @@ jobs:
pull-requests: read
statuses: write
steps:
- name: Generate app token
id: app-token
uses: actions/create-github-app-token@v3
with:
client-id: ${{ secrets.GH_APP_CLIENT_ID }}
private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
- name: Checkout
uses: actions/checkout@v5
with:
Expand All @@ -3505,7 +3509,7 @@ jobs:
id: semantic
uses: splunk/semantic-release-action@v1.3
env:
GITHUB_TOKEN: ${{ secrets.GH_TOKEN_ADMIN }}
GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
with:
git_committer_name: ${{ secrets.SA_GH_USER_NAME }}
git_committer_email: ${{ secrets.SA_GH_USER_EMAIL }}
Expand All @@ -3516,7 +3520,7 @@ jobs:
id: custom
uses: "softprops/action-gh-release@v3"
with:
token: "${{ secrets.GH_TOKEN_ADMIN }}"
token: "${{ steps.app-token.outputs.token }}"
tag_name: v${{ github.event.inputs.custom-version }}
target_commitish: "${{github.ref_name}}"
make_latest: false
Expand Down
Loading