Skip to content

fix: generate Swagger artifacts independently of UCC test selection#520

Open
rasteja wants to merge 1 commit into
splunk:developfrom
rasteja:fix/addon-89264-swagger-artifacts
Open

fix: generate Swagger artifacts independently of UCC test selection#520
rasteja wants to merge 1 commit into
splunk:developfrom
rasteja:fix/addon-89264-swagger-artifacts

Conversation

@rasteja

@rasteja rasteja commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes missing Swagger client artifacts when an add-on contains UCC modinput tests but that GitHub run does not select
UCC modinput test execution.

Root cause

Swagger/OpenAPI artifact upload was gated by execute-ucc_modinput. For builds where UCC tests were skipped,
swagger_client was never generated or uploaded to the build-specific S3 prefix. TACO later failed with:

ModuleNotFoundError: No module named swagger_client

Changes

  • Detect whether the add-on contains tests/ucc_modinput_functional.
  • Upload and consume artifact-openapi based on that capability, rather than the UCC test-selection flag.
  • Keep UCC modinput test execution behavior unchanged.

Impact

Builds for add-ons with UCC modinput tests now publish the Swagger artifact required by TACO even when the GitHub UCC
test job is skipped.

Validation

  • Parsed the GitHub Actions workflow YAML successfully.
  • Verified the workflow diff has no whitespace errors.

Related

  • ADDON-89264
  • TACO follow-up will validate the downloaded artifact and fail early if swagger_client/__init__.py is absent.

Checklist

  • README.md has been updated or is not required
  • push trigger tests
  • manual release test
  • automated releases test
  • pull request trigger tests
  • schedule trigger tests
  • workflow errors/warnings reviewed and addressed

Testing done

(for each selected checkbox, the corresponding test results link should be listed here)

@rasteja
rasteja requested a review from a team as a code owner July 17, 2026 09:19
@rasteja

rasteja commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: f9509629b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant