fix: make GS Scorecard non-blocking for releases (#505) [sync develop to main]#519
Conversation
## Summary - GS Scorecard tool remains available via `execute_gs_scorecard` label — developers can still use it - Scorecard results (pass/fail/missing) are now reported as `::warning::` instead of `::error::` and never cause the job to fail - Removed the `pre-publish` gate that blocked releases when scorecard was skipped on PRs to main - Fixes cases where scorecard flags checks as not checked, unintentionally blocking releases https://github.com/splunk/splunk-add-on-for-cisco-esa/actions/runs/27544575031/job/81415137332?pr=480#step:9:268 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b20b7916ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Print GS Scorecard report | ||
| run: | | ||
| if [ ! -f ./gs_scorecard.json ]; then | ||
| echo "::error::GS Scorecard report not found" | ||
| exit 1 | ||
| echo "::warning::GS Scorecard report not found" | ||
| exit 0 |
There was a problem hiding this comment.
In the run-gs-scorecard job, these warnings only run after the preceding Run GS Scorecard Docker step has succeeded. For any labeled PR or main push where the container exits non-zero (for example, if the tool reports failed checks via its process status), GitHub stops the job before this print step, so the workflow still ends with a failed quality-gs-scorecard job instead of the intended informational warning. Consider making the scorecard run continue on error and running the upload/print steps with always() if scorecard failures are meant to be non-blocking.
Useful? React with 👍 / 👎.
|
The comment near |
3 participants
Summary
execute_gs_scorecardlabel — developers can still use it::warning::instead of::error::and never cause the job to failpre-publishgate that blocked releases when scorecard was skipped on PRs to mainhttps://github.com/splunk/splunk-add-on-for-cisco-esa/actions/runs/27544575031/job/81415137332?pr=480#step:9:268
🤖 Generated with Claude Code
Description
(PR description goes here)
Checklist
README.mdhas been updated or is not requiredTesting done
(for each selected checkbox, the corresponding test results link should be listed here)