fix: fix composite actions paths#203
Closed
awownysz-splunk wants to merge 2 commits into
Closed
Conversation
awownysz-splunk
marked this pull request as draft
December 14, 2023 06:29
awownysz-splunk
force-pushed
the
fix/lightweight-workflow-ADDON-66448
branch
from
December 20, 2023 01:15
01cc1ed to
50ec106
Compare
awownysz-splunk
force-pushed
the
fix/lightweight-workflow-ADDON-66448
branch
from
December 20, 2023 03:31
d242989 to
1227eae
Compare
awownysz-splunk
marked this pull request as ready for review
December 20, 2023 03:37
awownysz-splunk
commented
Dec 20, 2023
| ref: ${{ steps.get-ref.outputs.caller-ref }} | ||
| steps: | ||
| - id: get-ref | ||
| uses: splunk/addonfactory-workflow-addon-release/.github/actions/_called-wf-ref@fix/lightweight-workflow-ADDON-66448 |
Contributor
Author
There was a problem hiding this comment.
Please note that this PR can't be merged until this line is changed to uses: splunk/addonfactory-workflow-addon-release/.github/actions/_called-wf-ref@main. This is the only action that is supposed to be always called from main.
awownysz-splunk
force-pushed
the
fix/lightweight-workflow-ADDON-66448
branch
from
December 20, 2023 12:05
efe070c to
9f1d93d
Compare
awownysz-splunk
marked this pull request as draft
December 27, 2023 12:39
Contributor
Author
|
This PR has been put on hold until this GitHub Actions issue is fixed: actions/toolkit#1264 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements following changes:
Sample workflow run: https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/7270633478
Some workarounds needed to be applied in order to achieve the result described above:
_called-wf-refwas implemented which allows the reusable workflow to access the ref (tag, branch, etc.) with which it was called (see this issue: make reference accessible in reusable workflow actions/toolkit#1264)dynamic-usesaction was utilised to allow for using the composite actions' versions dynamically - i.e. to be able to apply the ref that was previously extracted with_called-wf-ref