feat(lyrics-plus): optimize musixmatch API calls - #3909
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughMusixmatch lyric requests now include compact rich-sync data. ChangesMusixmatch rich-sync integration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change reduces redundant Musixmatch requests without any supplied merge-blocking correctness or operational risk; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Optimizes the Musixmatch API calls in the
lyrics-pluscustom app by preventing redundant network requests when syncing karaoke lyrics. Previously,findLyricswould callmacro.subtitles.get, and if karaoke syncing was needed,getKaraokewould make a separate follow-up call totrack.richsync.get.By appending
track.richsyncas an optional call to the initialmacro.subtitles.getparameter,getKaraokecan now extract the richsync payload directly from the combined response body. This eliminates the need for a separateSpicetify.CosmosAsync.getrequest, effectively cutting network calls in half to improve load times and reduce traffic.Summary by CodeRabbit
New Features
Bug Fixes