Reject database filenames and VFS names containing NUL - #732
Merged
Conversation
`Database.new` silently truncated a filename containing an embedded NUL at the NUL, then opened the truncated path with the default `READWRITE | CREATE` flags. A path that passed application-level checks in full could therefore open, or create, a different file than the application validated. The `zvfs` argument and UTF-16 filenames were truncated the same way. Ruby stdlib path APIs raise `ArgumentError` on embedded NUL; this extension did not. `Database.new` will now raise `ArgumentError` when the filename or VFS name contains an embedded NUL byte, or when a UTF-16 filename contains an embedded 0x0000 code unit, and will not open or create any file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database.newsilently truncated a filename containing an embedded NUL at the NUL, then opened the truncated path with the defaultREADWRITE | CREATEflags. A path that passed application-level checks in full could therefore open, or create, a different file than the application validated. Thezvfsargument and UTF-16 filenames were truncated the same way. Ruby stdlib path APIs raiseArgumentErroron embedded NUL; this extension did not.Database.newnow raisesArgumentErrorwhen the filename or VFS name contains an embedded NUL byte, or when a UTF-16 filename contains an embedded 0x0000 code unit, and does not open or create any file.