Pass TEXT values containing embedded NULs to UDFs intact - #730
Merged
Conversation
TEXT values containing an embedded NUL byte were stored whole, but functions created with `Database#define_function` received them truncated at the first NUL, so any validation or content-policy decision the function made ran on only a prefix of the stored value. `sqlite3val2rb` will now build the Ruby string with the explicit byte length reported by sqlite, matching the BLOB branch, so function blocks will receive the complete value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEXT values containing an embedded NUL byte were stored whole, but functions created with
Database#define_functionreceived them truncated at the first NUL, so any validation or content-policy decision the function made ran on only a prefix of the stored value.sqlite3val2rbnow builds the Ruby string with the explicit byte length reported by sqlite, matching the BLOB branch, so function blocks receive the complete value.