Fix issues surfaced while resolving PR merge conflicts - #1254
Merged
Conversation
- Align react to 19.2.8 to match react-dom (mismatch from an earlier dependabot merge that bumped only react-dom, breaking every React test suite). - Port #1231's non-superseded pieces now that #1241 (not #1231) is the chosen API-client-split design: LandingPage aria-describedby wiring to the API-error message, and useI18n's document.documentElement.lang sync effect. - Fix six test files still importing `api` from the legacy lib/api/client.ts barrel (re-exports admin-client's api) while LandingPage/Statistics now import from public-client.ts — the mocks were silently not applying, letting real fetch calls leak through and break the newsletter-signup mock in the same test.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while resolving conflicts across the frontend PR batch:
apivia the legacylib/api/client.tsbarrel while the components under test (LandingPage,Statistics) now import frompublic-client.tspost-fix: split API client into public and admin modules (#1158) #1241 — the mocks were silently inert, letting real fetch calls through and breaking test isolation.All of
src/components/__tests__/andsrc/lib/(260 tests) pass after this fix.