Skip to content

solid-v2: dim user pages with isPending during navigation - #286

Open
brenelz wants to merge 1 commit into
solidjs:mainfrom
brenelz:solid-v2-prerelease-bumps
Open

solid-v2: dim user pages with isPending during navigation#286
brenelz wants to merge 1 commit into
solidjs:mainfrom
brenelz:solid-v2-prerelease-bumps

Conversation

@brenelz

@brenelz brenelz commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Applies the v2 pending-navigation pattern to the user detail pages in basic, fullstack, and fullstack-tanstack: dim the section to 0.5 opacity with isPending while a navigation refreshes the async user data, and in fullstack-tanstack also drop the artificial 1s delay in the getUser server function.

Originally this PR also carried the solid/tanstack prerelease bumps, but those landed directly on main (along with the typed-argument mutation reshape), so it's been rebased down to just the UI changes on top of that shape.

Verified against current main: pnpm run build succeeds in all three templates and the fullstack-tanstack vitest suite passes (10 tests).

(The earlier note here about useMutation's STRICT_READ_UNTRACKED warning is resolved upstream via TanStack/query#11325, which flight-scopes the mutation-cache subscription.)

🤖 Generated with Claude Code

@socket-security

socket-security Bot commented Aug 29, 2026

Copy link
Copy Markdown

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@ryansolid

Copy link
Copy Markdown
Member

Heads up — main moved under this one today: the version bumps here (solid rc.4, vite-plugin next.35, @solidjs/router next.19, tanstack solid-router rc.4 + router-plugin 1.168.35, solid-query 6.0.0-rc.1) all landed directly on main, along with a reshape of the fullstack-tanstack mutations to typed arguments (validated end-to-end against the published packages). So this will conflict on every manifest/lockfile.

The unique part is worth keeping though: the v2 pending-navigation pattern on the user detail pages (direct async reads + isPending dimming instead of <Show> gating) and dropping the artificial delay. Suggest rebasing this down to just those UI changes — note fullstack-tanstack/src/routes/users.$id.tsx and lib/users.ts changed on main (typed-arg mutations, no more FormData), so the pattern would apply on top of that shape.

Also FYI on the note in the description: the STRICT_READ_UNTRACKED fix went a different route than TanStack/query#11324 — the mutation-cache subscription is now flight-scoped (created per mutation run, torn down at settle), see TanStack/query#11325.

Read user data directly (it suspends on first load) and fade the section
to 0.5 opacity while a pending navigation refreshes it, instead of
gating on <Show>. Also drop the artificial 1s delay in the
fullstack-tanstack getUser server function.
@brenelz brenelz changed the title solid-v2: bump solid and tanstack prereleases solid-v2: dim user pages with isPending during navigation Aug 29, 2026
@brenelz
brenelz force-pushed the solid-v2-prerelease-bumps branch from b3ebbcd to 46c4415 Compare August 29, 2026 20:30
@brenelz

brenelz commented Aug 29, 2026

Copy link
Copy Markdown
Contributor Author

Updated. Yeah I thought maybe having an example of isPending would be good to have in the templates. Not required by any means

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants