solid-v2: dim user pages with isPending during navigation - #286
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
|
Heads up — main moved under this one today: the version bumps here (solid rc.4, vite-plugin next.35, @solidjs/router next.19, tanstack solid-router rc.4 + router-plugin 1.168.35, solid-query 6.0.0-rc.1) all landed directly on main, along with a reshape of the fullstack-tanstack mutations to typed arguments (validated end-to-end against the published packages). So this will conflict on every manifest/lockfile. The unique part is worth keeping though: the v2 pending-navigation pattern on the user detail pages (direct async reads + Also FYI on the note in the description: the |
Read user data directly (it suspends on first load) and fade the section to 0.5 opacity while a pending navigation refreshes it, instead of gating on <Show>. Also drop the artificial 1s delay in the fullstack-tanstack getUser server function.
b3ebbcd to
46c4415
Compare
|
Updated. Yeah I thought maybe having an example of isPending would be good to have in the templates. Not required by any means |
Applies the v2 pending-navigation pattern to the user detail pages in
basic,fullstack, andfullstack-tanstack: dim the section to 0.5 opacity withisPendingwhile a navigation refreshes the async user data, and infullstack-tanstackalso drop the artificial 1s delay in thegetUserserver function.Originally this PR also carried the solid/tanstack prerelease bumps, but those landed directly on main (along with the typed-argument mutation reshape), so it's been rebased down to just the UI changes on top of that shape.
Verified against current main:
pnpm run buildsucceeds in all three templates and thefullstack-tanstackvitest suite passes (10 tests).(The earlier note here about
useMutation'sSTRICT_READ_UNTRACKEDwarning is resolved upstream via TanStack/query#11325, which flight-scopes the mutation-cache subscription.)🤖 Generated with Claude Code