Skip to content

Add a hook to observe server function errors before serialization #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adipascu wants to merge 1 commit into from
Closed

Add a hook to observe server function errors before serialization #2192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/start/src/fns/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ export async function handleServerFunction(h3Event: H3Event) {
h3Event.res.headers.set("content-type", "text/plain");
return serializeToJSONStream(result);
} catch (x) {
// Give monitoring a chance to observe server-function failures before
// they are serialized into the response, since no error hook fires for
// them today. Thrown Responses are control flow (redirects, forbidden),
// not errors.
if (!(x instanceof Response)) (globalThis as any).__reportServerFnError?.(x);
if (x instanceof Response) {
if (singleFlight && instance) {
x = await handleSingleFlight(event, x);
Expand Down
Loading